Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Added possibility to use the GithubAPI. #813

Closed
wants to merge 3 commits into from

Conversation

saigkill
Copy link
Contributor

@saigkill saigkill commented Sep 8, 2024

This Pull Request enables a option to access the Github Api. Currently implemented is the request for Repositories from the user.
Users Full path to Github Profile is saved into SocialProfileSettings. Also there are a possibility to add some other Social Profile Links. So they can used into custom pages.

… any page, to list as example our repositories.
Copy link

gitguardian bot commented Sep 8, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8476440 Triggered Generic Password 8e92815 src/Moonglade.Web/Controllers/SettingsController.cs View secret
8476440 Triggered Generic Password d8e0d93 src/Moonglade.Web/Controllers/SettingsController.cs View secret
8476440 Triggered Generic Password d8e0d93 src/Moonglade.Web/Controllers/SettingsController.cs View secret
8476440 Triggered Generic Password 8e92815 src/Moonglade.Web/Controllers/SettingsController.cs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@WeihanLi
Copy link
Contributor

WeihanLi commented Sep 8, 2024

@EdiWang maybe we could use dotnet-format to unify the code style and verify the code style when PR drafted

@saigkill
Copy link
Contributor Author

saigkill commented Sep 8, 2024

@WeihanLi Thanks for your comment. I haven't noticed, that Mads Kristensens "Code Cleanup on Save" was enabled. I used dotnet format on my last PR. So it should be better.

@EdiWang
Copy link
Owner

EdiWang commented Sep 11, 2024

This design is providing fixed number of third party links. A better approach is to let user add any number of links with icons they want. So providing a UI with a JSON editor would be better, since Moonglade users are all developers. Just like how the "Custom menus" is designed.

image

@saigkill
Copy link
Contributor Author

@EdiWang I think that would be the best option. Maybe we can provide some predefined tags for that. Maybe the user creates a new link and set a provider tag, what can be "Linkedin" or "Facebook". So wen can ensure, that we can find a specific entry by its provider name. I will look at your code for the menu.

@EdiWang
Copy link
Owner

EdiWang commented Oct 14, 2024

Close as tracked by #831

@EdiWang EdiWang closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants