chore: add HE, UA, update action versions, add json validation
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeerick
force-pushed
the
more-translations
branch
from
df3ee13 to
8da5a24
Compare
Validates all JSON and YML files by default
pfeerick
force-pushed
the
more-translations
branch
from
8da5a24 to
4f33ee5
Compare
pfeerick
changed the title
HE, UAHE, UA, update action versions, add json validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HE - Hebrew is only supported on colorlcd atm
UA - Ukrainian is colorlcd focused, but may partially work on B&W
Note: UA is supported from 2.10 onwards (as is RU, incidentally), so it is normal and expected that if anyone tries to build earlier firmwares with either of those translation flags that the build will fail.
While I was here, might as well update all the actions as necessary due to the NodeJS 16 depreciation... there is now a (strictly informational) warning regarding go action caching now, but that may go away after this is merged or on the next full proper run, as I don't think it has had a chance to build it's cache yet (but
go.sumfile appears to be present)... https://github.com/actions/setup-go?tab=readme-ov-file#caching-dependency-files-and-build-outputsAlso, add a JSON (and as a bonus YML) validation step that will fail the PR checks if any of the JSON or YML files are invalid (as it appears
ui/tsconfig.jsonwas as comments are explicitly not valid in JSON).Will merge in 24 hours unless instructed otherwise (or I forget 😆 )