fix: Color contrast issue

[itsharshitrwt]

This issue fixes the problems related to background and foreground color visibility.

Fixes #120

Screenshots

Color - Analyzer tests:-
(For white color)

(For Green color)

Summary by CodeRabbit

• Style
  • Updated text colors and class names in the activity component for improved visibility and aesthetics.

[vercel]

@itsharshitrwt is attempting to deploy a commit to the EddieHub Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The recent modifications primarily focus on enhancing visual accessibility and aesthetic appeal within the UI. By adjusting text colors for better contrast and readability, these changes aim to address accessibility concerns while also refreshing the UI's look.

Changes

File(s)	Change Summary
src/components/Activity.js	Updated class names and text colors for better contrast and visual accessibility.

Assessment against linked issues

Objective	Addressed	Explanation
Address the insufficient color contrast issue (#120)	❌	The changes do not match the specified foreground color #74859b for accessibility.
Modify the foreground color to #74859b and retain the original background color #0f1623 (#120)	❌	The foreground colors have been changed to "text-white" and "text-green-500", not #74859b.
Verify the accessibility of the new colors using a color analyzer app before implementation (#120)	❓	It's unclear if a color analyzer app was used to verify the accessibility of the new colors.

Poem

In the realm of code, where changes are bold,
A rabbit hopped in, with intentions gold.
🐇💻 With tweaks and twists, the UI shines,
"For accessibility," it chimes.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 405383e and f154f51.

Files selected for processing (1)

• src/components/Activity.js (1 hunks)

Additional comments: 3

src/components/Activity.js (3)

• 64-64: The class name for the time element has been updated to "text-white" to improve contrast and readability. This change aligns with the PR objectives to enhance accessibility by ensuring text elements are easily distinguishable against their background. However, it's important to verify that this change does not conflict with other design elements and maintains the overall aesthetic of the application.
• 69-69: The paragraph element's text color has been updated to "text-green-500" from a lighter shade of gray. While this change aims to improve readability and accessibility, it's crucial to ensure that the chosen shade of green meets the contrast ratio requirement mentioned in the PR objectives. Additionally, consider verifying this change with a color analyzer app to confirm compliance with accessibility standards.
• 61-72: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-93]

Overall, the file structure and logic appear to be well-organized and functional. The changes made to the class names and text colors are targeted and specific, focusing on enhancing accessibility. It's recommended to conduct thorough testing, especially with screen readers, to ensure that these changes effectively improve the user experience for individuals relying on assistive technologies. Additionally, consider documenting the accessibility testing process and results to provide evidence of compliance with accessibility standards.

[CBID2]

Hi @itsharshitrwt. I highly recommend reading coderabbit’s feedback on your contribution.

[Abiji-2020]

Have changed the colour white to gray-600 and gray to green in text-sm

I personally think it will be better if the colours are mentioned in hex values which will be better in many aspects

[itsharshitrwt]

Hi @Abiji-2020 , Thank you for your valuable feedback , but I'm quiet confused because Eddie said not to apply custom colors. Can you please elaborate it more like via screenshot?
Thanks

[Abiji-2020]

Hi @Abiji-2020 , Thank you for your valuable feedback , but I'm quiet confused because Eddie said not to apply custom colors. Can you please elaborate it more like via screenshot? Thanks.

This was the changes made by you
.

and the preferred colour changes in the issue is being given as

by providing the hex values of the colours for foreground and background. So in my personal opinion it is better if the colours are given in the hex value

[CBID2]

Hi @Abiji-2020 , Thank you for your valuable feedback , but I'm quiet confused because Eddie said not to apply custom colors. Can you please elaborate it more like via screenshot? Thanks.

This was the changes made by you, and the preferred colour changes in the issue is being made as .

.

by providing the hex values of the colours for foreground and background. So in my personal opinion it is better if the colours are given in the hex value

Hi @Abiji-2020. When it comes to displaying code, it's best to do them as snippets like this:

<img src="url">

It'll make it easier for people to understand your points

[Abiji-2020]

Hi @Abiji-2020 , Thank you for your valuable feedback , but I'm quiet confused because Eddie said not to apply custom colors. Can you please elaborate it more like via screenshot? Thanks.

This was the changes made by you, and the preferred colour changes in the issue is being made as .
.
by providing the hex values of the colours for foreground and background. So in my personal opinion it is better if the colours are given in the hex value

Hi @Abiji-2020. When it comes to displaying code, it's best to do them as snippets like this:

<img src="url">

It'll make it easier for people to understand your points

Thankyou @CBID2 hereafter I try to follow those

[eddiejaoude]

Using tailwind colours is great 👍 There should be enough options without needing to create new colours as suggested by CodeRabbit

[eddiejaoude]

Thank you 👍

[CBID2]

Yay you made your first open source contribution @itsharshitrwt! 😊

[itsharshitrwt]

Thankyou so much Everyone for helping me 😊 specially @CBID2 .

[CBID2]

Thankyou so much Everyone for helping me 😊 specially @CBID2 .

Yup! :) I highly recommend using this website to post about contribution.
Also, now that you've made your first contribution, I highly recommend checking out pizza-verse. It's one of OpenSauced's many repos that you can contribute to, and it focuses on pizza :)

[itsharshitrwt]

Hi Folks , I checked the reporater's website , When i opened the website first time everything looks fine but when i opened it second time i see the green color is added to links and not to the "Rated " element and also white color was not visible to the time element . I'm just concerned about it now.😔 Even though the first time i opened it everything went as expected.

Screenshot:

[itsharshitrwt]

Thankyou so much Everyone for helping me 😊 specially @CBID2 .

Yup! :) I highly recommend using this website to post about contribution. Also, now that you've made your first contribution, I highly recommend checking out pizza-verse. It's one of OpenSauced's many repos that you can contribute to, and it focuses on pizza :)

Thanks @CBID2 , I will surely checkout the website.

[eddiejaoude]

Hi Folks , I checked the reporater's website , When i opened the website first time everything looks fine but when i opened it second time i see the green color is added to links and not to the "Rated " element and also white color was not visible to the time element . I'm just concerned about it now.😔 Even though the first time i opened it everything went as expected.

I moved the colours around after merging your PR, you can check the commit history - I thought the repo url will be better to be more highlighted instead

[itsharshitrwt]

Hi Folks , I checked the reporater's website , When i opened the website first time everything looks fine but when i opened it second time i see the green color is added to links and not to the "Rated " element and also white color was not visible to the time element . I'm just concerned about it now.😔 Even though the first time i opened it everything went as expected.

I moved the colours around after merging your PR, you can check the commit history - I thought the repo url will be better to be more highlighted instead

Thanks Eddie for clarifying this , I got worried that I made some mistake 😅.