Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

Update the nav elements active status using Pathname #24

Closed

Conversation

Muhammad-Owais-Warsi
Copy link
Member

@Muhammad-Owais-Warsi Muhammad-Owais-Warsi commented Jul 12, 2024

Fixes Issue Closes #17

Changes proposed

  • Used usePathname to get the current path.
  • Using that current path , I update the tailwind dynamically.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot 2024-07-13 004356

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 👍

Why is there "use client" everywhere?

@Muhammad-Owais-Warsi
Copy link
Member Author

@eddiejaoude on removing the use client from those places raise errors. Like Object.groupBy is not a function etc..

@eddiejaoude
Copy link
Member

Please go through and check your changes, "use client" should not be required. I would recommend checking your local node version as this might be causing the problem.

@Muhammad-Owais-Warsi
Copy link
Member Author

@eddiejaoude please review and let me know if any changes required.

@eddiejaoude
Copy link
Member

@Muhammad-Owais-Warsi please recheck each of your changes and make sure you are happy with them, because there are so many unnecessary changes

@Muhammad-Owais-Warsi
Copy link
Member Author

@eddiejaoude to me it seems to be fine.

@eddiejaoude
Copy link
Member

I will comment a few examples in line

@@ -195,7 +196,7 @@ const repo = {
subscribers_count: 54,
};

const results = checks(repo);
const results = checks(repo);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this change is required?

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making further changes, but more are still required. I have left some example inline comments

Please recheck that all changes in your PR are changes you are happy with, such as extra line changes resulting in files being included in your PR that should not be

@Muhammad-Owais-Warsi
Copy link
Member Author

Thank you for making further changes, but more are still required. I have left some example inline comments

Please recheck that all changes in your PR are changes you are happy with, such as extra line changes resulting in files being included in your PR that should not be

Sorry for the inconvenience, I'll recheck and let you know.

@Muhammad-Owais-Warsi
Copy link
Member Author

@eddiejaoude Please review , I don't think anything should cause any problem now

@eddiejaoude
Copy link
Member

Thank you for your contribution. As there were still unnecessary changes this PR could not be merge, and now as there are conflicts also, I have made a PR to solve this issue #43, so I will close this PR.

Hopefully my PR will highlight the changes required, for example the existing condition was the main change only required
https://github.com/EddieHubCommunity/HealthCheck/pull/43/files#diff-6a1559e4b25e80b6a3b7c9c6b7d24db73177617ee8efbc935fae6fd8a59d1667R170

@Muhammad-Owais-Warsi
Copy link
Member Author

Thanks @eddiejaoude , will try to improve next time

@eddiejaoude
Copy link
Member

Thanks @Muhammad-Owais-Warsi for the collaboration

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar not updating the active state on click
2 participants