Custom sounds not working after API update (#47)

* fix: custom sounds were not working after API update * version bump
EddieDover · Feb 18, 2024 · b1ff582 · b1ff582
1 parent f265ec4
commit b1ff582
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+#### 1.2.3 (2024-02-18)
+
+##### Bug Fixes
+
+*  custom sounds were not working after API update ([b4153ba2](https://github.com/EddieDover/fvtt-player-achievements/commit/b4153ba2a0484a71bba79311f00032daca444c63))
+
 ## 1.2.2 (2024-02-08)
 
 ##### Bug Fixes

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "fvtt-player-achievements",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "Player Achievements for Foundry VTT",
   "main": "index.js",
   "author": {

diff --git a/src/module.json b/src/module.json
@@ -44,7 +44,7 @@
       "url": "https://github.com/eddiedover/"
     }
   ],
-  "version": "1.2.2",
+  "version": "1.2.3",
   "compatibility": {
     "minimum": "11",
     "verified": "11"

diff --git a/src/module/core.js b/src/module/core.js
@@ -50,7 +50,7 @@ export function setupAchievementSocket() {
  * @property {string} description Description
  * @property {string} image Image URL
  * @property {string} cloakedImage Cloaked Image URL
- * @property {string} soundEffect Sound Effect URL
+ * @property {string} sound Sound Effect URL
  * @property {Array} completedActors Array of Actor UUIDs
  * @property {boolean} showTitleCloaked Show Title Cloaked
  */
@@ -59,7 +59,7 @@ export function setupAchievementSocket() {
  * Create an Achievement
  * @param {Achievement} achievement The achievement
  */
-export function createAchievement({ id, title, showTitleCloaked, description, image, cloakedImage, soundEffect }) {
+export function createAchievement({ id, title, showTitleCloaked, description, image, cloakedImage, sound }) {
   const customAchievements = game.settings.get("fvtt-player-achievements", "customAchievements");
   customAchievements.push({
     id,
@@ -68,7 +68,7 @@ export function createAchievement({ id, title, showTitleCloaked, description, im
     description,
     image: image ?? DEFAULT_IMAGE,
     cloakedImage: cloakedImage ?? DEFAULT_IMAGE,
-    soundEffect: soundEffect ?? DEFAULT_SOUND,
+    sound: sound ?? DEFAULT_SOUND,
   });
   game.settings.set("fvtt-player-achievements", "customAchievements", customAchievements);
 }
@@ -77,13 +77,13 @@ export function createAchievement({ id, title, showTitleCloaked, description, im
  * Edit an Achievement
  * @param {Achievement} achievement The achievement
  */
-export function editAchievement({ id, title, showTitleCloaked, description, image, cloakedImage, soundEffect }) {
+export function editAchievement({ id, title, showTitleCloaked, description, image, cloakedImage, sound }) {
   const customAchievements = game.settings.get("fvtt-player-achievements", "customAchievements");
   const index = customAchievements.findIndex((a) => a.id === id);
   if (index === -1) {
     return;
   }
-  customAchievements[index] = { id, title, showTitleCloaked, description, image, cloakedImage, soundEffect };
+  customAchievements[index] = { id, title, showTitleCloaked, description, image, cloakedImage, sound };
   game.settings.set("fvtt-player-achievements", "customAchievements", customAchievements);
 }