Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logscale options #61

Merged
merged 10 commits into from
Oct 18, 2020
Merged

Added logscale options #61

merged 10 commits into from
Oct 18, 2020

Conversation

OhadNir9
Copy link
Contributor

@OhadNir9 OhadNir9 commented Oct 8, 2020

No description provided.

Still produces buggy figure
@OhadNir9
Copy link
Contributor Author

OhadNir9 commented Oct 8, 2020

Graph of exponential function fit with y axis logscaled:
image

I managed to solve the axis format issue with FuncFormatter, but still not in scientific style (100000 instead of 10^5).

In second thought, maybe the problem is in toga, because the CLI produces good figures.

@saroad2
Copy link
Member

saroad2 commented Oct 18, 2020

Thank you @OhadNir9 for the contribution!

I didn't change a lot of things, just moved the scaling switches next to the axis titles text inputs, and added command shortcuts to toggle those switches (ctrl+x and xcrl+y).

I fixed the ticks problem using the FuncFormatter as you did in EddLabs/eddington#104. The reason for that bug is because of beeware/toga-chart#11. We have to wait until it is fixed in order to solve the problem here. Until then, at least we have something that works.

If you have the time and endurance to try and solve the problem in toga-chart, that would be awesome. I didn't get the chance to sit down and try to tackle this bug because of prior commitments.

@saroad2 saroad2 merged commit 367893d into EddLabs:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants