Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ODS-6193] Github build and package publish #948

Merged
merged 4 commits into from
Feb 14, 2024
Merged

[ODS-6193] Github build and package publish #948

merged 4 commits into from
Feb 14, 2024

Conversation

semalaiappan
Copy link
Contributor

@semalaiappan semalaiappan commented Feb 7, 2024

There is many workflow changed the name ,so it requires merge to main first to verify the publish nuget package step
name: Lib EdFi.Admin.DataAccess
name: Lib EdFi.Common
name: Lib EdFi.LoadTools
name: Lib EdFi.Ods.Api
name: Lib EdFi.Ods.Common
name: Lib EdFi.Ods.Standard
name: Lib EdFi.Security.DataAccess
Updated Branches condition to match it with Patch release requirement
image

@semalaiappan semalaiappan requested a review from a team as a code owner February 7, 2024 02:17
@semalaiappan semalaiappan force-pushed the ODS-6193 branch 2 times, most recently from fda8d6e to f619591 Compare February 7, 2024 18:01
Copy link
Contributor

@axelmarquezh axelmarquezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the 'feature-*' pattern to the list of branches so that the relevant workflows get executed for PRs that target feature branches.

@@ -6,7 +6,7 @@
name: Cleanup Caches by a branch
on:
pull_request:
branches: [main, 'ODS-*']
branches: [main, b-v*-patch*,feature-*]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should include the quotes, at least that's how it appears in GitHub examples:
image

@semalaiappan semalaiappan merged commit 66b1001 into main Feb 14, 2024
15 checks passed
@semalaiappan semalaiappan deleted the ODS-6193 branch February 14, 2024 19:20
@semalaiappan
Copy link
Contributor Author

verified - publish for below packages name: Lib EdFi.Admin.DataAccess
name: Lib EdFi.Common
name: Lib EdFi.LoadTools
name: Lib EdFi.Ods.Api
name: Lib EdFi.Ods.Common
name: Lib EdFi.Ods.Standard
name: Lib EdFi.Security.DataAccess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants