[ODS-6111] Update EdFi.Security.DataAccess to .Net 8 #929
Conversation
There was a problem hiding this comment.
With this ODS/API 6.2 update to .NET 8, please keep in mind that we do not want to copy any changes from main except for those changes that are specifically related to .NET 8.
In some circumstances we can also apply small C# improvements so long as we are 100% sure they do not change the way the code works.
There was a problem hiding this comment.
Please restore this file. It is still used in ODS/API 6.x code (see EdFi.Ods.Api.Container.Modules.SecurityRepositoryModule). In ODS/API 7.x there were some recent changes to improve or remove some of the caching, which probably explains why this file would have been removed from the main branch.
There was a problem hiding this comment.
@JBrenesSimpat the tests for CachedSecurityRepository use StubSecurityContext, which no longer compiles cleanly since they removed IDbSet from Entity Framework Core 😠 .
There may be some other work around, but in this case we need to simply stop trying to unit test the repository. It would be ideal if we had some integration tests that access the database.
The unit tests are kind of interesting but there is not a lot of business logic to test here. We should delete the unit test file and StubSecurityContext.
Application/EdFi.Security.DataAccess/Repositories/ISecurityRepository.cs
Outdated
Show resolved
Hide resolved
Application/EdFi.Security.DataAccess/Repositories/ISecurityRepository.cs
Outdated
Show resolved
Hide resolved
Application/EdFi.Security.DataAccess/Repositories/SecurityRepository.cs
Outdated
Show resolved
Hide resolved
Application/EdFi.Security.DataAccess/Repositories/SecurityRepository.cs
Outdated
Show resolved
Hide resolved
tests/EdFi.Security.DataAccess.UnitTests/Repositories/CachedSecurityRepositoryTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@JBrenesSimpat the tests for CachedSecurityRepository use StubSecurityContext, which no longer compiles cleanly since they removed IDbSet from Entity Framework Core 😠 .
There may be some other work around, but in this case we need to simply stop trying to unit test the repository. It would be ideal if we had some integration tests that access the database.
The unit tests are kind of interesting but there is not a lot of business logic to test here. We should delete the unit test file and StubSecurityContext.
No description provided.