[ODS-6510] Apply DRY principle to security/authorization logic (through consolidation of common code) #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gmcelhanon
commented
Oct 13, 2024
•
gmcelhanon
commented
…t eliminates the need for individual dependencies on multiple context providers.
…it test coverage.
…ation basis provider with full unit test coverage of new classes.
…ts -- pending removal.
…e types and subtype inclusion. Fixing unit tests and specflow tests.
mjaksn
requested changes
Oct 14, 2024
...Fi.Ods.Security/Authorization/AuthorizationBasis/RequestEvaluationStrategiesSelectorTests.cs
Outdated
Show resolved
Hide resolved
...tion/EdFi.Ods.Api/Security/Authorization/AuthorizationBasis/AuthorizationStrategyResolver.cs
Outdated
Show resolved
Hide resolved
Application/EdFi.Ods.Api/Security/Authorization/EntityAuthorization/EntityAuthorizer.cs
Outdated
Show resolved
Hide resolved
...s.Security/Authorization/EntityAuthorization/EntityInstanceViewBasedFilterAuthorizerTests.cs
Outdated
Show resolved
Hide resolved
...s.Security/Authorization/EntityAuthorization/EntityInstanceViewBasedFilterAuthorizerTests.cs
Outdated
Show resolved
Hide resolved
...s.Security/Authorization/EntityAuthorization/EntityInstanceViewBasedFilterAuthorizerTests.cs
Outdated
Show resolved
Hide resolved
Application/EdFi.Ods.Tests/EdFi.Ods.Security/Authorization/EdFiAuthorizationProviderTests.cs
Outdated
Show resolved
Hide resolved
mjaksn
reviewed
Oct 15, 2024
Application/EdFi.Ods.Api/Security/Extensions/EdFiAuthorizationContextExtensions.cs
Outdated
Show resolved
Hide resolved
mjaksn
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.