[ODS-6435] Use preinstalled Microsoft SQL Server in Rebuild Database Templates.yml #1135
Conversation
| run: git config --system core.longpaths true | ||
| - name: Set permissions for database server container backup directory | ||
| run: docker exec --user root mssql chmod 777 /DatabaseBackups | ||
| shell: bash |
There was a problem hiding this comment.
Can you change it to pwsh instead of bash ?
There was a problem hiding this comment.
@semalaiappan , can you elaborate on the reasoning for changing bash to pwsh? Bash is the default shell on Ubuntu, and the steps where this change is requested are all intended to execute a binary on the Ubuntu host. The "Set permissions for database server container backup directory" steps directly invoke the docker executable on the runner host, and the "Set permissions for database backup file" steps execute a Linux-specific command (chmod), which modifies permissions on the Ubuntu host's file system in a way without a direct equivalent in windows or PowerShell. I don't believe the change to pwsh would cause any harm. However, I hesitate to use pwsh if its unique capabilities are not required. It appears that for these steps, it would only act as an additional layer that the one-line commands must pass through to run in the underlying Ubuntu environment.
There was a problem hiding this comment.
I understand your point . we are always using pwsh script in all steps in github actions workflows . That's the reason . Thank you !
@vimayya Please advice .
There was a problem hiding this comment.
This specific command would run equally well in Bash or PowerShell.
Personally, I still use Bash commands sometimes, just for practice, but in general I prefer to have PowerShell commands in our GitHub runner steps. Since most of us are running Windows computers, having PowerShell commands in the Actions workflows makes it easier for us to manually test those commands locally.
| - name: Set permissions for database backup file | ||
| working-directory: ./ | ||
| run: sudo chmod -R 777 $GITHUB_WORKSPACE/Ed-Fi-ODS-Implementation/DatabaseTemplate/Database/ | ||
| shell: bash |
There was a problem hiding this comment.
Can you change it to pwsh instead of bash ?
| run: git config --system core.longpaths true | ||
| - name: Set permissions for database server container backup directory | ||
| run: docker exec --user root mssql chmod 777 /DatabaseBackups | ||
| shell: bash |
There was a problem hiding this comment.
Can you change it to pwsh instead of bash ?
| - name: Set permissions for database backup file | ||
| working-directory: ./ | ||
| run: sudo chmod -R 777 $GITHUB_WORKSPACE/Ed-Fi-ODS-Implementation/DatabaseTemplate/Database/ | ||
| shell: bash |
There was a problem hiding this comment.
Can you change it to pwsh instead of bash ?
| run: git config --system core.longpaths true | ||
| - name: Set permissions for database server container backup directory | ||
| run: docker exec --user root mssql chmod 777 /DatabaseBackups | ||
| shell: bash |
There was a problem hiding this comment.
Can you change it to pwsh instead of bash ?
| - name: Set permissions for database backup file | ||
| working-directory: ./ | ||
| run: sudo chmod -R 777 $GITHUB_WORKSPACE/Ed-Fi-ODS-Implementation/DatabaseTemplate/Database/ | ||
| shell: bash |
There was a problem hiding this comment.
Can you change it to pwsh instead of bash ?
| run: git config --system core.longpaths true | ||
| - name: Set permissions for database server container backup directory | ||
| run: docker exec --user root mssql chmod 777 /DatabaseBackups | ||
| shell: bash |
There was a problem hiding this comment.
Can you change it to pwsh instead of bash ?
| - name: Set permissions for database backup file | ||
| working-directory: ./ | ||
| run: sudo chmod -R 777 $GITHUB_WORKSPACE/Ed-Fi-ODS-Implementation/DatabaseTemplate/Database/ | ||
| shell: bash |
There was a problem hiding this comment.
Can you change it to pwsh instead of bash ?
No description provided.