Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BIA-1351] Update AMT to .NET 8 and Latest Packages #243

Merged
merged 8 commits into from
Nov 20, 2023
Merged

Conversation

jleiva-gap
Copy link
Contributor

@jleiva-gap jleiva-gap commented Nov 15, 2023

  • Upgrade projects to use NET 8.0.

  • Upgrade packages:

    • Dapper
    • dbup-core
    • dbup-postgresql
    • dbup-sqlserver
    • dotenv.net
    • FakeItEasy
    • Microsoft.SqlServer.DacFx
    • Microsoft.NET.Test.Sdk
    • Npgsql
    • nunit
    • NUnit3TestAdapter
    • Shouldly
  • Update github actions to include .NET 8 setup.

  • Upgrade actions/* version to remove warnings related to deprecated functions.

Upgrade projects to use NET 8.0.
Upgrade packages:
- Dapper
- dbup-core
- dbup-postgresql
- dbup-sqlserver
- dotenv.net
- FakeItEasy
- Microsoft.SqlServer.DacFx
- Microsoft.NET.Test.Sdk
- Npgsql
- nunit
- NUnit3TestAdapter
- Shouldly
Test .net setup
Update action version
Add action to install NET 8
@jleiva-gap jleiva-gap marked this pull request as ready for review November 16, 2023 20:30
@jleiva-gap jleiva-gap marked this pull request as draft November 16, 2023 20:31
Upgrade deprecated actions
@jleiva-gap jleiva-gap marked this pull request as ready for review November 17, 2023 01:20
Comment on lines 3 to 6
ENV PACKAGE_URL "https://github.com/Ed-Fi-Alliance-OSS/Ed-Fi-Analytics-Middle-Tier"
ENV PACKAGE_NAME "EdFi.AnalyticsMiddleTier"
ENV AMT_VERSION "2.9.1"
ENV AMT_VERSION "4.0.0"
ENV RELEASE_URL "${PACKAGE_URL}/releases/download/${AMT_VERSION}/${PACKAGE_NAME}-${AMT_VERSION}.zip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that these ENV statements work without = in them.

@stephenfuqua stephenfuqua merged commit d5dfc51 into main Nov 20, 2023
8 checks passed
@stephenfuqua stephenfuqua deleted the BIA-1351 branch November 20, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants