ECWID-134977 OE2: if an advanced discount is used for a product and m…

…ore items are added to an order, the total is calculated incorrectly: added fields into DiscountInfo
Ecwid · Apr 1, 2024 · e2fc235 · e2fc235
1 parent 03e102a
commit e2fc235
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 4 deletions.
diff --git a/src/main/kotlin/com/ecwid/apiclient/v3/converter/FetchedOrder.kt b/src/main/kotlin/com/ecwid/apiclient/v3/converter/FetchedOrder.kt
@@ -106,7 +106,9 @@ fun FetchedOrder.DiscountInfo.toUpdated(): UpdatedOrder.DiscountInfo {
 		type = type,
 		base = base,
 		orderTotal = orderTotal,
-		description = description
+		description = description,
+		appliesToProducts = appliesToProducts,
+		appliesToItems = appliesToItems,
 	)
 }
 

diff --git a/src/main/kotlin/com/ecwid/apiclient/v3/dto/order/request/UpdatedOrder.kt b/src/main/kotlin/com/ecwid/apiclient/v3/dto/order/request/UpdatedOrder.kt
@@ -107,7 +107,9 @@ data class UpdatedOrder(
 		val type: DiscountType? = null,
 		val base: DiscountBase? = null,
 		val orderTotal: Double? = null,
-		val description: String? = null
+		val description: String? = null,
+		val appliesToProducts: Set<Int?>? = null,
+		val appliesToItems: Set<Long>? = null,
 	)
 
 	data class DiscountCouponInfo(

diff --git a/src/main/kotlin/com/ecwid/apiclient/v3/dto/order/result/FetchedOrder.kt b/src/main/kotlin/com/ecwid/apiclient/v3/dto/order/result/FetchedOrder.kt
@@ -1,7 +1,10 @@
 package com.ecwid.apiclient.v3.dto.order.result
 
-import com.ecwid.apiclient.v3.dto.common.*
+import com.ecwid.apiclient.v3.dto.common.ApiFetchedDTO
 import com.ecwid.apiclient.v3.dto.common.ApiFetchedDTO.ModifyKind
+import com.ecwid.apiclient.v3.dto.common.ExtendedOrderTax
+import com.ecwid.apiclient.v3.dto.common.OrderedStringToListStringMap
+import com.ecwid.apiclient.v3.dto.common.OrderedStringToStringMap
 import com.ecwid.apiclient.v3.dto.order.enums.*
 import com.ecwid.apiclient.v3.dto.order.request.UpdatedOrder
 import java.util.*
@@ -125,7 +128,9 @@ data class FetchedOrder(
 		val type: DiscountType? = null,
 		val base: DiscountBase? = null,
 		val orderTotal: Double? = null,
-		val description: String? = null
+		val description: String? = null,
+		val appliesToProducts: Set<Int?>? = null,
+		val appliesToItems: Set<Long>? = null,
 	)
 
 	data class DiscountCouponInfo(

diff --git a/src/test/kotlin/com/ecwid/apiclient/v3/rule/nullablepropertyrules/FetchedOrderRules.kt b/src/test/kotlin/com/ecwid/apiclient/v3/rule/nullablepropertyrules/FetchedOrderRules.kt
@@ -43,6 +43,8 @@ val fetchedOrderNullablePropertyRules: List<NullablePropertyRule<*, *>> = listOf
 	IgnoreNullable(FetchedOrder.DiscountInfo::orderTotal),
 	IgnoreNullable(FetchedOrder.DiscountInfo::type),
 	IgnoreNullable(FetchedOrder.DiscountInfo::value),
+	AllowNullable(FetchedOrder.DiscountInfo::appliesToProducts),
+	AllowNullable(FetchedOrder.DiscountInfo::appliesToItems),
 	AllowNullable(FetchedOrder.ExtraFieldsInfo::customerInputType),
 	AllowNullable(FetchedOrder.ExtraFieldsInfo::id),
 	AllowNullable(FetchedOrder.ExtraFieldsInfo::orderBy),