[DA] Support logical expressions in templates #49 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logical expressions in templates were not being explicitly handled in
template-literal-indent-fix.js, so our bundling process would remove those expressions completely.It could be reproduced by putting code under
src/such asand inspecting the output (eg
build/umd/bundle.development.js). The logical expressions would be completely stripped. This PR ensures those expressions are not stripped.PR Requirements
Before requesting review this criteria must be met:
Overall test coverage >= current master?
Documentation included (if any behavioral changes)?
Backwards compatibility (if breaking change)?
Release
Will this pr trigger a release i.e.
versioninpackage.jsonhas been bumped?