Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file parsing #2

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Add file parsing #2

merged 6 commits into from
Dec 3, 2024

Conversation

Ecnama
Copy link
Owner

@Ecnama Ecnama commented Nov 26, 2024

This PR adds functions to get a well-formatted dataframe from the spreadsheet file given in input.

@Ecnama Ecnama added the enhancement New feature or request label Nov 26, 2024
@Ecnama Ecnama self-assigned this Nov 26, 2024
@Ecnama Ecnama linked an issue Nov 26, 2024 that may be closed by this pull request
Copy link
Collaborator

@pixup1 pixup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@@ -0,0 +1,104 @@
library(openxlsx)
library(readODS)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to document these imports inside ADSPlanner-package.R and then run devtools::document(), or else they won't work when the package is compiled. (Check out my PR)

Copy link
Collaborator

@pixup1 pixup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok lgtm 👍👍👍👍

@Ecnama Ecnama merged commit cda890e into dev Dec 3, 2024
1 check passed
@Ecnama Ecnama deleted the input-processing branch December 3, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Processing input file
3 participants