-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file parsing #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
e92575c
to
f4b020b
Compare
0b0a96f
to
0a4168f
Compare
@@ -0,0 +1,104 @@ | |||
library(openxlsx) | |||
library(readODS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to document these imports inside ADSPlanner-package.R
and then run devtools::document()
, or else they won't work when the package is compiled. (Check out my PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok lgtm 👍👍👍👍
8cd3cb8
to
cda890e
Compare
This PR adds functions to get a well-formatted dataframe from the spreadsheet file given in input.