-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add photo-viwer to manually apply noir filter to a photo in camera roll #4
Open
haxpor
wants to merge
13
commits into
Echorridoors:master
Choose a base branch
from
haxpor:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d sucessfully show photo viewer. Changed bundle identifier to com.xxiivv.noirca-photo. This will be changed back to normal when photo viewer feature allowing other images to take benefit from processing with noir filter is done.
…era roll's photos when loading assets.
…h modal view. Still need to add processing code later.
…erfaceState.xcuserstate file.
Wow this is amazing, would you like me to release it? |
@aliceffekt Please feel free Devine, as per your consideration :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes I need to apply noir filter to my own photo that has been taken via non-noirca app. Thus having this kind of ability within an app itself would be nice.
To access this functionality, tap on the top of the screen (tilesize). It will display photo-viewer.
Then select one of photo (currently only support a single filter apply to selected photos).
It then applies noir filter (noir input filter and sharp-noir filter) over an input image.
The project integrate MWPhotoBrowser, and take benefit from MBProgressHUD to show activity hud during waiting for tasks to be carried out.
**This is a base commit for this feature, it still needs some more work.
Selected photo
Selected photo after applying to noir filter
Photo Viewer
HUDs