Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added solidity course #11740

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

anand-242003
Copy link

@anand-242003 anand-242003 commented Oct 31, 2024

What does this PR do?

Add resource(s)

For resources

Description

Added solidity course "* Solidity Smart Contract Development - Patrick Collins, Austin Griffith”

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@anand-242003 anand-242003 changed the title Add solidity course Added solidity course Oct 31, 2024
Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-en.md
1701:1-1707:119  warning  Alphabetical ordering: swap l.1707 and l.1706                          alphabetize-lists  remark-lint
1701:1-1707:119  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

@github-actions github-actions bot added the linter error Please, correct build errors found by linter! label Oct 31, 2024
@github-actions github-actions bot removed the linter error Please, correct build errors found by linter! label Oct 31, 2024
@eshellman
Copy link
Collaborator

please remove the package-lock file (use a .gitignore file)

@Thenlie Thenlie added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 31, 2024
@eshellman
Copy link
Collaborator

hmm the linter doesn't like adding that to .gitignore
instead, just remove the file from your repo; we'll figure out how to manage changes to gitignore separately

@anand-242003
Copy link
Author

I've removed package-lock.json from the repository as the linter didn't approve of adding it to .gitignore. Could you please guide me on the next steps or any further changes needed?

@eshellman
Copy link
Collaborator

maybe you need to push your commits

@anand-242003
Copy link
Author

I've made the changes and pushed them again. Let me know if there's anything else I should adjust .

@eshellman
Copy link
Collaborator

I see the problem. you ned to undo your change to .gitignore

@@ -290,3 +290,4 @@ dist
# #########################################################
# User Custom
# ########
package-lock.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
package-lock.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commit these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants