Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests #54

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Fix unit tests #54

merged 3 commits into from
Jan 26, 2024

Conversation

Greybird
Copy link
Contributor

Description

Fix unit tests that are not passing anymore, as https://api.ipify.org/ does not support POST calls anymore.

Testing

The change is only on testing code, and makes failing tests pass.

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Greybird Greybird requested a review from a team January 26, 2024 17:49
@nwithan8
Copy link
Member

Hey there! Thanks so much for your contribution and for catching this!

Code looks good. I was going to suggest using HTTPBin, but seems like you're one step ahead of me.

(TIL about Postman Echo. Also TIL HTTPBin was developed by Postman and hasn't been updated in years... which means it's probably going away soon...).

There's an issue with our CI right now that's causing the checks to fail. We're going to fix that right now, and then after a rebase, this should be good to approve and merge!

Thanks again!

@nwithan8 nwithan8 merged commit 6b8f7ee into EasyPost:master Jan 26, 2024
12 checks passed
@Greybird Greybird deleted the fix/tests-using-proxy branch February 5, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants