Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Fix address verification unit tests #293

Merged
merged 1 commit into from
Jan 8, 2024
Merged

[chore] Fix address verification unit tests #293

merged 1 commit into from
Jan 8, 2024

Conversation

nwithan8
Copy link
Contributor

@nwithan8 nwithan8 commented Jan 8, 2024

Description

See EasyPost/easypost-csharp#540 for more details.

  • Update examples submodule for new "incorrect address" fixture
  • Update address verification unit tests to better test target functionality

Testing

  • Update unit tests, re-record cassettes as needed

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team January 8, 2024 19:09
@nwithan8 nwithan8 merged commit 9346186 into master Jan 8, 2024
7 checks passed
@nwithan8 nwithan8 deleted the incorrect_address branch January 8, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justintime50 Justintime50 Justintime50 approved these changes

@jchen293 jchen293 jchen293 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @jchen293 @Justintime50