EE::notice() support
#1582
Closed
EE::notice() support
#1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling ee auth create or ee auth delete, a deprecation warning will be shown. create/delete is add/remove now.
Instead of using EE::warning(), EE::notice() can be used to print (deprecation) notices. Prints a message prefixed with "Notice: " in yellow.
|
@danish17 I have a better approach to accomplish the same thing you did here. Checkout - #1606. It's better as in:
Because of these resons, it's best that you create a new PR addressing the above points. I'll be closing this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
Instead of using
EE::warning()to output (deprecation) notices,EE::notice()can be used.EE::notice()will print a nice deprecation notice prefixed with "Notice: " in yellow.It is being used for printing deprecation notices while using
ee auth create/delete.Files
php/EE/Loggers/Regular.phpphp/EE/Runner.phpphp/class-ee.php