Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
…ingUi into develop

# Conflicts:
#	src/EasyAbp.Abp.SettingUi.Application/SettingUiAppService.cs
  • Loading branch information
wakuflair committed Jul 7, 2020
2 parents 45e44c0 + a80eff1 commit 75f5dfb
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/EasyAbp.Abp.SettingUi.Application/SettingUiAppService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public class SettingUiAppService : ApplicationService, ISettingUiAppService
private readonly ISettingDefinitionManager _settingDefinitionManager;
private readonly ISettingManager _settingManager;

public SettingUiAppService(IStringLocalizer<SettingUiResource> localizer,
public SettingUiAppService(IStringLocalizer<SettingUiResource> localizer,
IStringLocalizerFactory factory,
IVirtualFileProvider fileProvider,
IJsonSerializer jsonSerializer,
Expand Down Expand Up @@ -124,14 +124,14 @@ private List<SettingInfo> SetSettingDefinitionProperties(IDictionary<string, IDi
foreach (var settingDefinition in settingDefinitions)
{
var si = CreateSettingInfo(settingDefinition);
string settingName = si.Name;
if (settingProperties.ContainsKey(settingName))
if (settingProperties.ContainsKey(si.Name))
{
// This Setting is defined in the property file,
// set its property values from the dictionary
var properties = settingProperties[settingName];
var properties = settingProperties[si.Name];
foreach (var kv in properties)
{
// Do not assign the property if it has already been set by the user.
if (!si.Properties.ContainsKey(kv.Key))
{
si.WithProperty(kv.Key, kv.Value);
Expand Down Expand Up @@ -180,7 +180,7 @@ private SettingInfo CreateSettingInfo(SettingDefinition settingDefinition)
string value = AsyncHelper.RunSync(() => SettingProvider.GetOrNullAsync(name));

var si = new SettingInfo(name, displayName, description, value);

// Copy properties from SettingDefinition
foreach (var property in settingDefinition.Properties)
{
Expand Down

0 comments on commit 75f5dfb

Please sign in to comment.