Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a way to limit xp used with /cenchant #667

Open
wants to merge 1 commit into
base: fabric
Choose a base branch
from

Conversation

Starmania
Copy link
Contributor

This is useful when you want to use as little xp level as possible.

How did I tested this pr:

[23:05:15] [Render thread/INFO]: [CHAT] Player RNG cracked: c1700935c5bb

[23:05:17] [Render thread/INFO]: [CHAT] maxExperienceConsumed has been set to 1.

[23:05:23] [Render thread/INFO]: [CHAT] Starting enchantment manipulation. Cancel
[23:05:23] [Render thread/INFO]: [CHAT] Item throws needed: 8 (about 0.4 seconds)
[23:05:23] [Render thread/INFO]: [CHAT] Bookshelves needed: 5
[23:05:23] [Render thread/INFO]: [CHAT] In slot: 1
[23:05:23] [Render thread/INFO]: [CHAT] Enchantments on item:
[23:05:23] [Render thread/INFO]: [CHAT] - Aqua Affinity

[23:05:24] [Render thread/INFO]: [CHAT] maxExperienceConsumed has been set to 3.

[23:05:27] [Render thread/INFO]: [CHAT] Starting enchantment manipulation. Cancel
[23:05:27] [Render thread/INFO]: [CHAT] Item throws needed: 5 (about 0.25 seconds)
[23:05:27] [Render thread/INFO]: [CHAT] Bookshelves needed: 13
[23:05:27] [Render thread/INFO]: [CHAT] In slot: 3
[23:05:27] [Render thread/INFO]: [CHAT] Enchantments on item:
[23:05:27] [Render thread/INFO]: [CHAT] - Power III
[23:05:27] [Render thread/INFO]: [CHAT] - Aqua Affinity

I can rename the config option to getMaxExperienceLevelConsumed or something like that but it's becoming pretty long. As you want.

@Earthcomputer
Copy link
Owner

This is the same as which slot to use, so could it be renamed to maxEnchantSlot or something? I think that's clearer

@Starmania
Copy link
Contributor Author

Yeah, why not... Naming variables is the most difficult thing to do.

@Earthcomputer Earthcomputer added the enhancement New feature or request label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants