Add /cdebug command #650
Merged
Add /cdebug command #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xpple
requested changes
Jun 24, 2024
src/main/java/net/earthcomputer/clientcommands/command/CDebugCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/CDebugCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/CDebugCommand.java
Outdated
Show resolved
Hide resolved
xpple
reviewed
Jun 29, 2024
src/main/java/net/earthcomputer/clientcommands/command/CDebugCommand.java
Outdated
Show resolved
Hide resolved
xpple
reviewed
Jun 30, 2024
src/main/java/net/earthcomputer/clientcommands/command/CDebugCommand.java
Outdated
Show resolved
Hide resolved
xpple
approved these changes
Jun 30, 2024
RealRTTV
reviewed
Jun 30, 2024
src/main/java/net/earthcomputer/clientcommands/command/CDebugCommand.java
Outdated
Show resolved
Hide resolved
RealRTTV
suggested changes
Jun 30, 2024
|
why can't a CEnumArgument be used here? |
sorry, i just noticed that you wrote 2 comments and I wasn't aware of the CEnumArgument. |
|
Sorry to bother, but what's the status on this PR? |
|
It is currently open. |
|
Yeah, but I mean if it's going to be merged sometime, if the feature seems unnecessary and not getting added or if I need to update something on the code. Sry for not clarifying. If you don't know yet, it's also ok, just wanted to ask |
xpple
requested changes
Jul 7, 2024
src/main/java/net/earthcomputer/clientcommands/command/CDebugCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/CDebugCommand.java
Outdated
Show resolved
Hide resolved
xpple
reviewed
Jul 7, 2024
src/main/java/net/earthcomputer/clientcommands/command/CDebugCommand.java
Outdated
Show resolved
Hide resolved
RealRTTV
suggested changes
Jul 7, 2024
src/main/java/net/earthcomputer/clientcommands/command/CDebugCommand.java
Show resolved
Hide resolved
xpple
approved these changes
Jul 7, 2024
|
Thank you! For such a simple command, it went through quite a lot of reviewing 😄. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command opens up the debug screen (F3) for the people who do not have the F3 key on their keyboard.
You can also use
/cdebug fps|network|profilerto show the respective graphs.