Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when typing "/ " in chat #615

Closed
wants to merge 2 commits into from
Closed

Fix crash when typing "/ " in chat #615

wants to merge 2 commits into from

Conversation

DeltAndy123
Copy link
Contributor

Fixes #610

Earthcomputer
Earthcomputer requested changes Mar 29, 2024
View reviewed changes
Copy link
Owner

@Earthcomputer Earthcomputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a cleaner fix would be to assign the array to a variable and check its length before getting the first string.

Earthcomputer added a commit that referenced this pull request Mar 29, 2024
@Earthcomputer @DeltAndy123
Fix crash while typing "/" in chat (#615)
1b9b344 
Co-authored-by: Andy <[email protected]>
@Earthcomputer
Copy link
Owner

Merged with changes, thanks!

@DeltAndy123 DeltAndy123 deleted the fix-crash branch March 30, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Earthcomputer Earthcomputer Awaiting requested review from Earthcomputer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash via indexing out of array
2 participants
@DeltAndy123 @Earthcomputer