Add the clisten command #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirmed that both methods work in 1.20.5 (at least currently), see xpple:clisten+1.20.5. |
# Conflicts: # src/main/java/net/earthcomputer/clientcommands/ClientCommands.java # src/main/resources/mixins.clientcommands.json
|
Confirmed to work after port to mojmap, no mappings issues in dev or prod. |
Earthcomputer
requested changes
Feb 17, 2024
src/main/java/net/earthcomputer/clientcommands/ReflectionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/UnsafeUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/ListenCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/ListenCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/ListenCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/features/MappingsHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/features/PacketDumper.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/features/PacketDumper.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/features/PacketDumper.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/net/earthcomputer/clientcommands/ClientCommands.java
src/main/java/net/earthcomputer/clientcommands/UnsafeUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/UnsafeUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/UnsafeUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/UnsafeUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/ListenCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/ClientCommands.java
Outdated
Show resolved
Hide resolved
Earthcomputer
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a command that lets the user listen to incoming or outgoing packets. The command supports two outputs that are configurable through the config
packetDumpMethod:REFLECTION. This output format displays the packet's data using reflection on the corresponding packet class. All fields of the packet will be recursively serialized toText(Component) providing a nice display for the user.BYTE_BUF. This output format displays the packet's data by keeping track of the calls to the methods inPacketByteBuf(FriendlyByteBuf) when the packet is serialized into it. The resulting output will be JSON. This packet dump method is written by @Gaming32.An example of method 1:
An example of method 2:
Another example of method 1:
Another example of method 2:
Since protocol related analysis is more natural in mojmap (wiki.vg/Protocol), everything related to this command is in that mapping as well. This necessitated the
MappingsHelperclass to go back and forth between mappings. Perhaps in the future we can further use this class for a basic/cmappingscommand.