-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add argo workflows #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to keep a set of diffs from the generated stuff?
@retnuh good idea! I created a diff file now. It's a bit noisy due to all the freeze also happening, but it gives a better idea of every change happened (including the import freezing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I don't think it matters here, and I obviously thought of it too late, but maybe in the future for things of this nature, it would make sense to have multiple patches - one for each of the discrete or logical changes. For example, one that was the freezing; another for removing the status, etc. 🤔 |
@retnuh good point. I will try to do it better next time (also with a more granular commit history) |
Or maybe just do the intermittent commits, and not worry about saving the diffs; just keep the git history (i.e. don't squash the merge)? Then we can let git do the diffing if we need it... |
This PR add dhall types and defaults for argo v2.3.0
The types have been generated from the swagger spec using dhall-kubernetes-generator (specifically the version in this pending PR which also generate records that support the new syntax).
The following manual interventions were necessary to make it compile:
io.k8s
files that you find in the types directory. These reference dhall-kubernetesstatus
from theWorkflow
type (status is fine on read but we shouldn't be using it on write)Long term plan is to probably directly fork and make dhall-kubernetes-generator do all this work.
Note: the types generated from the swagger spec are not perfect (e.g. use optional instead of union types) but since they are generated they are easier to maintain. We should build on top of these a higher level library for argo/kubeflow.