-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/odom #173
Merged
Merged
Feature/odom #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BOOMERANG was removed as a unique thing, and is now another flavor of pure pursuit. This simplified everything internally with no change to the user.
Fixed odom slew, general refactoring, exit conditions are now set correctly for normal drive moves after pure pursuit
Fixed some stuff in the example project, fixed slew constants, and commented out unused variables in tracking
the robot will actually go at a maximum speed now! tuned constants some more refactored some pid_tasks
and some simple refactoring
With this comes a new constructor that is unique to not overlap with "ratio" used previously, and removing "ratio" will create breaking changes. This new constructor takes in a motor group and it extracts that out into the ez motor groups. This currently doesn't work as there's a bug with `get_direction` that has an open issue on the PROS kernel. If a left and right tracker are enabled, the main sensors for the drive switch over to being these tracking wheels. If only one sensor is used, then this tracker is only used for odom. Normal drive motions will use IMEs still, as that PID uses a left and a right PID. Only one horizontal tracker will be used. Angle is currently always calculated with IMU. Until there's an easy way to tune track width, #45 will remain open.
Adding missing okapi unit functions, general cleaning and refactoring. Prep being done for documentation being added to drive.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds odometry along with unrelated fixes because I'm very good at using github correctly
Motivation:
Odometry allows users to do more!
References (optional):
Test Plan:
Download the template for this pull request:
Note
This is auto generated from
Add Template to Pull Request