-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the power drawn in the ISO 15118-2 DC demo to 160 kW #4
Conversation
@drmrd does this actually work? I believe it required a change to the image for it to work, and I don't see any image changes here... |
@shankari: It does not without additional work. The @couryrr-afs: Can you push the |
@drmrd should I be pushing a docker container? I can do so but it may become out of date if not automated with the CI/CD pipeline. I was having permission issues when doing attempting this previously. |
@couryrr-afs as you can see from the current workflow, you should be able to rebuild containers by submitting a PR to a branch that starts with I think we should revisit even the current cicd pipeline to tag the images by date/time instead of branch, so that we can keep a single |
@drmrd and @shankari it looks like this will push an image to the US-JOET. If we are okay with that for the time being then after this PR action runs the new image should have what is needed in the manager. The issue I was referring to was permission based for pushing images. As for the image versioning there are various build and tagging strategy that we can use. As the the CI/CD pipeline matures we can implement those. |
Yes, as outlined in the issue https://github.com/US-JOET/everest-demo-private/issues/16, this is the current process. We do not want the perfect to be the enemy of the good.
To get the PR action to run, you will need to submit a PR to us-joet. Since this is a common theme across the PRs, I have created a new branch for this -
images created by github actions automatically have permissions for pushing images
Yes, there are various strategies. Can you open an issue and make a proposal on which one to use? The current flow works for the interim, but is clearly very clunky |
b36969e
to
bb3265e
Compare
3ae6bb7
to
b2e6fc4
Compare
Signed-off-by: Daniel Moore <[email protected]>
Signed-off-by: Daniel Moore <[email protected]>
Signed-off-by: Daniel Moore <[email protected]>
19c97bd
to
497db45
Compare
@shankari: This PR should now be ready to merge. |
Fixes to get the simulation to work with the current HEAD
The current ISO 15118-2 DC demo includes a charger configured to provide power to a simulated EV at a rate of roughly 6 kW. These changes modify the charger configuration to up this rate to 160 kW, which is more representative of a typical DC fast charging session.