Add new single demo script for all ISO 15118-2 AC with OCPP demos #34
Conversation
|
@shankari please review! |
activeshadow
force-pushed
the
new-demo-script
branch
from
99b78e8
to
f8dfcec
Compare
|
@sahabulh just calling you out here for your situational awareness. Feel free to review as well! |
There was a problem hiding this comment.
@activeshadow thank you so much for cleaning up the proliferation of demo-XXX.sh scripts and for fixing the codacy checks so that all the checks pass.
Note that the OCPP v1.6j demo is currently not working with this new script (though it also wasn't working with the old script either).
The OCPP v1.6j demo worked with the old version of .env. I am going to test it out but then merge this since it is so much better than what we have now. We can fix any other issues later
|
I can confirm that the existing 1.6j demo works for me. See logs below + I can charge from the UI |
|
I pulled the changes into a local branch and they are not working for OCPP 1.6J but with a weird error. |
|
In spite of that error, both steve and occp-db seem to start, until steve has a java error on startup. I have seen this before, probably a memory error given that it happens while putting some data |
|
I just tried the same command back to back, it works on main but not on this branch I don't understand this; there are no changes to the @activeshadow what error do you see while running the 1.6J demo? @activeshadow if this pattern holds (works on |
|
Actually, I take that back. After testing ~ 10 times on main, I got the same SIGSEGV error twice. |
|
Ok, after trying ~ 5 times on the new branch, I got a single success. So:
@activeshadow please update the README with the instructions for the new method and flag that the 1.6J demo will fail intermittently, and we will not fix it I will then merge. |
|
@shankari I should be able to update the README tomorrow. |
activeshadow
force-pushed
the
new-demo-script
branch
from
f7e8dda
to
1737e30
Compare
This new script includes option flags for which demo to run. It also enables the option to test a user's local copy of this repo without having to edit the script or push commits up to GitHub first. Note that the OCPP v1.6j demo is currently not working with this new script (though it also wasn't working with the old script either). Signed-off-by: Bryan T. Richardson <[email protected]>
activeshadow
force-pushed
the
new-demo-script
branch
from
1737e30
to
45ca2f3
Compare
|
@shankari README has been updated and I've tested the one-liners where the script is curled and piped to bash. |
@activeshadow , Sorry! I am really busy with my PhD study. But I will test this tonight. |
Ok, I've tested the script with all 3 security profiles and everything works on my end. Similar to both of you, I also tested 1.6j with the script and was only able to get it to work once. |
|
@shankari Same thing for me. |
This new script includes option flags for which demo to run.
It also enables the option to test a user's local copy of this repo without having to edit the script or push commits up to GitHub first.
Note that the OCPP v1.6j demo is currently not working with this new script (though it also wasn't working with the old script either).
references #25