Fix alliance fetching, and handle if the id is null, which can happen…

… in rare circumstances
EVE-KILL · Oct 6, 2024 · 4de5f52 · 4de5f52
1 parent 890027f
commit 4de5f52
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/app/Jobs/UpdateAlliance.php b/app/Jobs/UpdateAlliance.php
@@ -24,11 +24,11 @@ public function __construct(
     public function handle(array $data): void
     {
         $allianceId = $data["alliance_id"];
-        if ($allianceId === 0) {
+        if ($allianceId === 0 || $allianceId === null) {
             return;
         }
 
-        $allianceData = $this->esiData->getAllianceInfo($allianceId, $updateHistory);
+        $allianceData = $this->esiData->getAllianceInfo($allianceId);
 
         $this->updateMeilisearch->enqueue([
             'id' => $allianceId,

diff --git a/app/Jobs/UpdateCharacter.php b/app/Jobs/UpdateCharacter.php
@@ -25,7 +25,7 @@ public function handle(array $data): void
     {
         $characterId = $data["character_id"];
         $updateHistory = $data["update_history"] ?? false;
-        if ($characterId === 0) {
+        if ($characterId === 0 || $characterId === null) {
             return;
         }
 

diff --git a/app/Jobs/UpdateCorporation.php b/app/Jobs/UpdateCorporation.php
@@ -25,7 +25,7 @@ public function handle(array $data): void
     {
         $corporationId = $data["corporation_id"];
         $updateHistory = $data["update_history"] ?? false;
-        if ($corporationId === 0) {
+        if ($corporationId === 0 || $corporationId === null) {
             return;
         }