Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc comment for pool::allocate() #914

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

kmichaelk
Copy link
Contributor

The documentation comment for pool::allocate() in include/etl/pool.h states that the default constructor is to be called, while according to the documentation and to the code (including the documentation comment for generic_pool::allocate()) it is not true.

Copy link

Review changes with SemanticDiff.

@jwellbelove jwellbelove merged commit 744d54c into ETLCPP:master Jul 14, 2024
63 checks passed
jwellbelove pushed a commit that referenced this pull request Jul 23, 2024
* Fix doc comment for pool::allocate() (#914)

* Fix issue #931

Superfluous curly braces removed

---------

Co-authored-by: Michael K <[email protected]>
jwellbelove pushed a commit that referenced this pull request Jul 28, 2024
* Fix doc comment for pool::allocate() (#914)

* Fixes compiler detection with Wunder

---------

Co-authored-by: Michael K <[email protected]>
Co-authored-by: Rafael Laya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants