Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RTW review comments #2863

Merged

Conversation

mo-tgeddes
Copy link
Contributor

@mo-tgeddes mo-tgeddes commented Oct 17, 2022

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic

New or updated data reformatting script


To help with the number of pull requests:

@mo-tgeddes mo-tgeddes added the Recipe Test Workflow (RTW) Items relevant to the Recipe Test Workflow label Oct 17, 2022
@mo-tgeddes mo-tgeddes self-assigned this Oct 17, 2022
@mo-tgeddes mo-tgeddes requested review from ehogan and KatherineTomkins and removed request for valeriupredoi October 19, 2022 07:32
@ehogan ehogan changed the title Recipe test workflow prototype review Implement RTW review comments Jun 26, 2023
Copy link
Contributor

@ehogan ehogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mo-tgeddes! :)

The following lines should be removed from esmvaltool/utils/recipe_test_workflow/recipe_test_workflow/opt/rose-suite-metoffice.conf, since they already exist in esmvaltool/utils/recipe_test_workflow/recipe_test_workflow/rose-suite.conf

DRS_OBS="default"
DRS_OBS4MIPS="default"

@mo-tgeddes
Copy link
Contributor Author

Thanks @mo-tgeddes! :)

The following lines should be removed from esmvaltool/utils/recipe_test_workflow/recipe_test_workflow/opt/rose-suite-metoffice.conf, since they already exist in esmvaltool/utils/recipe_test_workflow/recipe_test_workflow/rose-suite.conf

DRS_OBS="default"
DRS_OBS4MIPS="default"

Done a17f876 :)

@mo-tgeddes mo-tgeddes requested a review from ehogan June 28, 2023 13:02
@ehogan ehogan linked an issue Jun 28, 2023 that may be closed by this pull request
@ehogan ehogan merged commit dc26604 into recipe_test_workflow_prototype Jun 28, 2023
@ehogan ehogan deleted the recipe_test_workflow_prototype_review branch June 28, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Recipe Test Workflow (RTW) Items relevant to the Recipe Test Workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement RTW review comments
4 participants