Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume the 4th component is always mach_comp and the 5th always testmods #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

billsacks
Copy link
Member

This removes some generality - specifically, it removes the ability to
specify a search string like:

name.grid.compset.testmods

However, the smarts that were trying to determine if a component was the
testmods seemed overly restrictive, and were stopping it from finding
some matches. There were two problems with the previous code:

(1) It assumed that there is exactly one '-' in the testmods; this is
usually the case, but not always

(2) It assumed that it could find the testmods directory under the
current directory. This was an issue e.g. for CISM, where we use
some CLM testmods

This removes some generality - specifically, it removes the ability to
specify a search string like:

  name.grid.compset.testmods

However, the smarts that were trying to determine if a component was the
testmods seemed overly restrictive, and were stopping it from finding
some matches. There were two problems with the previous code:

(1) It assumed that there is exactly one '-' in the testmods; this is
    usually the case, but not always

(2) It assumed that it could find the testmods directory under the
    current directory. This was an issue e.g. for CISM, where we use
    some CLM testmods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants