update "radians" to "rad" #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacraigucar
approved these changes
Dec 5, 2024
nusbaume
approved these changes
Dec 8, 2024
peverwhee
added a commit
to ESCOMP/CAM-SIMA
that referenced
this pull request
Dec 10, 2024
Tag name (required for release branches): Originator(s): peverwhee Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number): Adds metadata for orbital parameters in cam_control_mod.F90 Describe any changes made to build system: N/A Describe any changes made to the namelist: N/A List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A List all files eliminated and why: N/A List all files added and what they do: A src/control/cam_control_mod.meta - add metadata file for cam_control_mod.F90 List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...<your_branch_name>`) M .gitmodules - update atmospheric_physics hash to grab changes in ESCOMP/atmospheric_physics#173 M src/control/cam_control_mod.F90 - add necessary comments for CCPP parsing M src/data/registry.xml - notify the registry of the new metadata file M src/physics/units/physics_grid.meta - update "radians" to "rad" M test/unit/sample_files/phys_types_dup_section.meta - update "radians" to "rad" If there are new failures (compared to the `test/existing-test-failures.txt` file), have them OK'd by the gatekeeper, note them here, and add them to the file. If there are baseline differences, include the test and the reason for the diff. What is the nature of the change? Roundoff? derecho/intel/aux_sima: all non-existing failures PASS derecho/gnu/aux_sima: all non-existing failures PASS If this changes climate describe any run(s) done to evaluate the new climate in enough detail that it(they) could be reproduced: CAM-SIMA date used for the baseline comparison tests if different than latest:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originator(s): peverwhee
Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number):
Update units of "radians" to "rad" to adhere to SI unit conventions
closes #172
Describe any changes made to the namelist: none
List all files eliminated and why: none
List all files added and what they do: none
List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)
M schemes/held_suarez/held_suarez_1994.meta
M schemes/tj2016/tj2016_sfc_pbl_hs.meta
M schemes/tropopause_find/tropopause_find.meta
List any test failures: none
Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? no.