Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesh_maker doesn't work with surface dataset produced by subset_data #2774

Open
samsrabin opened this issue Sep 19, 2024 · 1 comment
Open
Labels
bug something is working incorrectly test: python Pass clm_pymods test suite plus Python sys/unit tests before merging

Comments

@samsrabin
Copy link
Collaborator

samsrabin commented Sep 19, 2024

General bug information

I'm not sure this is a problem, exactly—subset_data can produce a mesh file itself. But it's weird and could cause confusion.

(In fact, I'm not sure there's even a good use case for having a standalone mesh_maker that we need to support...)

CTSM version you are using: ctsm5.2.027

Does this bug cause significantly incorrect results in the model's science? No

Configurations affected: n/a

Important details of your setup / configuration so we can reproduce the bug

infile=/glade/work/samrabin/fates_grids/shuman_southam_halfdeg_ctsm5.2.013_2000_noLU/surfdata_shuman_southam_halfdeg_ctsm5.2.013_2000_noLU_hist_2000_78pfts_c240827.nc
outfile=shuman_mesh_test_2d.nc
tools/site_and_regional/mesh_maker --input $infile --output $outfile --lon LATIXY --lat LONGXY

Important output or errors that show the problem

WARNING: Corners have longitudes less than zero -- this will work, but may result in answers different to roundoff to corners within 0 to 360
ERROR: The size of unique coordinate pairs is 111 but expected size is 12321!
ERROR: Including a pole point in your grid is the usual reason for this problem
ERROR: Expected size for element connections is wrong

I think it should be easy enough to handle this—just generate the pairs from the unique values given (12321 = 111^2).

@samsrabin samsrabin added bug something is working incorrectly support tools only next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Sep 19, 2024
@samsrabin samsrabin removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Oct 3, 2024
@samsrabin
Copy link
Collaborator Author

@adrifoster will mention this in the discussion she's going to start.

@samsrabin samsrabin added test: python Pass clm_pymods test suite plus Python sys/unit tests before merging and removed support tools only labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is working incorrectly test: python Pass clm_pymods test suite plus Python sys/unit tests before merging
Projects
None yet
Development

No branches or pull requests

1 participant