Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cam_cesm2_2_rel_07: Functional support for FHIST on CONUS refined grid #695

Merged
merged 6 commits into from
Mar 2, 2023
Merged

cam_cesm2_2_rel_07: Functional support for FHIST on CONUS refined grid #695

merged 6 commits into from
Mar 2, 2023

Conversation

fvitt
Copy link

@fvitt fvitt commented Nov 11, 2022 •
edited
Loading

addresses #662 in cesm2.2
Closes #662
Closes #708 with its new test

@fvitt
Use 0.9x1.25 emissions as default for FHIST compset on CONUS grid
6a15903 
        modified:   bld/namelist_files/namelist_defaults_cam.xml
        modified:   cime_config/testdefs/testlist_cam.xml
@fvitt fvitt added this to the CESM2.2 milestone Nov 11, 2022
@fvitt fvitt requested a review from cacraigucar November 11, 2022 18:02
@fvitt fvitt self-assigned this Nov 11, 2022
@fvitt fvitt marked this pull request as ready for review November 28, 2022 23:45
fvitt added 3 commits February 14, 2023 16:35
@fvitt
Merge remote-tracking branch 'ESCOMP/cam_cesm2_2_rel' into cam_refine…
5a56f18 
…d_cesm2_2_rel
@fvitt
refined grid regression tests
30f716b 
        modified:   cime_config/testdefs/testlist_cam.xml
        new file:   cime_config/testdefs/testmods_dirs/cam/outfrq9s_refined/user_nl_cam
        new file:   cime_config/testdefs/testmods_dirs/cam/outfrq9s_refined/user_nl_clm
@fvitt
reduce pe count for CONUS test
d961d46
@fvitt
Copy link
Author

fvitt commented Feb 18, 2023

@cacraigucar PGI is no longer available on izumi. Should I just skip the izumi/pgi/aux_cam tests?

@fvitt fvitt requested a review from cacraigucar February 18, 2023 17:39
@fvitt fvitt added the BFB bit for bit tag label Feb 18, 2023
@fvitt
Copy link
Author

fvitt commented Feb 21, 2023 •
edited
Loading

Switching the izumi/PGI to GNU gives the following run failures:

FAIL ERC_D_Ln9.ne5_ne5_mg37.QPC5.izumi_gnu.cam-outfrq3s_ba RUN time=2
FAIL ERC_D_Ln9.ne5pg2_ne5pg2_mg37.FADIAB.izumi_gnu.cam-outfrq3s RUN time=2
FAIL ERC_D_Ln9.ne5pg4_ne5pg4_mg37.FADIAB.izumi_gnu.cam-outfrq3s RUN time=2
FAIL PEM_D_Ln9.ne5pg3_ne5pg3_mg37.FADIAB.izumi_gnu.cam-outfrq3s RUN time=2
FAIL PLB_D_Ln9.ne5pg3_ne5pg3_mg37.QPC5.izumi_gnu.cam-ttrac_loadbal0 RUN time=2
FAIL PLB_D_Ln9.ne5pg3_ne5pg3_mg37.QPC5.izumi_gnu.cam-ttrac_loadbal1 RUN time=2
FAIL PLB_D_Ln9.ne5pg3_ne5pg3_mg37.QPC5.izumi_gnu.cam-ttrac_loadbal3 RUN time=2
FAIL SCT_D_Ln7.T42_T42_mg17.QPC6.izumi_gnu.cam-scm_prep_c6 RUN time=21
FAIL SMS_D_Ln9.ne5pg3_ne5pg3_mg37.QPC5.izumi_gnu.cam-outfrq3s_ttrac RUN time=2

If there are no objections I will be skipping the izumi/PGI tests for this tag

@cacraigucar
Copy link
Collaborator

Switching the izumi/PGI to GNU gives the following run failures:

FAIL ERC_D_Ln9.ne5_ne5_mg37.QPC5.izumi_gnu.cam-outfrq3s_ba RUN time=2
FAIL ERC_D_Ln9.ne5pg2_ne5pg2_mg37.FADIAB.izumi_gnu.cam-outfrq3s RUN time=2
FAIL ERC_D_Ln9.ne5pg4_ne5pg4_mg37.FADIAB.izumi_gnu.cam-outfrq3s RUN time=2
FAIL PEM_D_Ln9.ne5pg3_ne5pg3_mg37.FADIAB.izumi_gnu.cam-outfrq3s RUN time=2
FAIL PLB_D_Ln9.ne5pg3_ne5pg3_mg37.QPC5.izumi_gnu.cam-ttrac_loadbal0 RUN time=2
FAIL PLB_D_Ln9.ne5pg3_ne5pg3_mg37.QPC5.izumi_gnu.cam-ttrac_loadbal1 RUN time=2
FAIL PLB_D_Ln9.ne5pg3_ne5pg3_mg37.QPC5.izumi_gnu.cam-ttrac_loadbal3 RUN time=2
FAIL SCT_D_Ln7.T42_T42_mg17.QPC6.izumi_gnu.cam-scm_prep_c6 RUN time=21
FAIL SMS_D_Ln9.ne5pg3_ne5pg3_mg37.QPC5.izumi_gnu.cam-outfrq3s_ttrac RUN time=2

If there are no objections I will be skipping the izumi/PGI tests for this tag

The AMP SE's agreed that if any difficulties were encountered in changing PGI to GNU, that we would skip the PGI testing for this tag. This was based on the determination that CESM2.2 is a "dead branch" and not worth the effort to port the tests. Also, since the changes are just namelist settings for CAM6, the only test which might potentially have an issue is the QPC6. But since there are numerous other tests which use QPC6, as long as they all pass, there shouldn't be an issue with the untested test.

jtruesdal
jtruesdal approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@jtruesdal jtruesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These mods look fine. Just for my information I'd also like to know why you can change the NCPL env variables.

nusbaume
nusbaume approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Only found one minor typo in the ChangeLog.

doc/ChangeLog

A cime_config/testdefs/testmods_dirs/cam/outfrq9s_refined/user_nl_cam
A cime_config/testdefs/testmods_dirs/cam/outfrq9s_refined/user_nl_clm
- for testing on refinded grids -- don't modify ROF_NCPL and GLC_NCPL
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here (refinded -> refined).

@adamrher
Copy link

adamrher commented Mar 1, 2023

@jtruesdal says

I'd also like to know why you can change the NCPL env variables.

This is new to me as well. I knew there was an issue with NUOPC where the ROF/GLC_NCPL needed to be increased and set to ATM_NCPL so it "lands" on a ROF/GLC coupling time-step at the end of the run (see Marianna's explanation: ESCOMP/CMEPS#255 (comment)). But this is MCT, and the issue is the opposite -- you CAN'T set these as is done in outfrq9s/shell_commands:

./xmlchange ROF_NCPL=\$ATM_NCPL
./xmlchange GLC_NCPL=\$ATM_NCPL

No idea why.

@cacraigucar cacraigucar changed the title Functional support for FHIST on CONUS refined grid cam_cesm2_2_rel_07: Functional support for FHIST on CONUS refined grid Mar 1, 2023
@fvitt fvitt merged commit f25480e into ESCOMP:cam_cesm2_2_rel Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nusbaume nusbaume nusbaume approved these changes

@cacraigucar cacraigucar cacraigucar approved these changes

@jtruesdal jtruesdal jtruesdal approved these changes

Assignees

@fvitt fvitt

Labels
BFB bit for bit tag
Projects
CAM Development
Status: Tag
Milestone
CESM2.2
Development

Successfully merging this pull request may close these issues.
5 participants
@fvitt @cacraigucar @adamrher @jtruesdal @nusbaume