Pertlim fix for MPAS #1114
Open
Pertlim fix for MPAS #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtruesdal
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
This mods are fine. @cacraigucar I was surprised that there aren't pertlim regression tests since ensembles are an important part of climate analysis. I'll bring that up in our SE meeting and see if we need an issue to provide testing for all supported dycores. Since we don't have testing currently in place please run your own test to make sure that the pertlim namelist addition is working correctly and document this in your Changelog.
|
@patcal - Could you please provide a test that you ran with this new pertlim that we can use as a basis of a CAM regression test? |
|
The test I ran was for a user-defined MPAS grid and user-generated input
files, so I don't think it is feasible for a standard regression test. I
have not checked
to see if there is a functional implementation of a uniform low-res MPAS
grid in
the current tag. If there is, then I can set up a test using it.
…On Tue, Aug 13, 2024 at 10:57 AM cacraigucar ***@***.***> wrote:
@patcal <https://github.com/patcal> - Could you please provide a test
that you ran with this new pertlim that we can use as a basis of a CAM
regression test?
—
Reply to this email directly, view it on GitHub
<#1114 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJMQHAKRAGN2X5MNFWARLX3ZRI3HPAVCNFSM6AAAAABLVDTAN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBWG4YDKOJSGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@patcal - Have you made any progress on creating a regression test? This PR is stalled until we get one made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1109