Skip to content

Commit

Permalink
Merge pull request #434 from fvitt/clbr_cesm2_2_rel
Browse files Browse the repository at this point in the history
Transport CL and BR when middle-atmosphere chemistry is used for CESM2.2
  • Loading branch information
fvitt authored Jan 6, 2023
2 parents a68ec28 + 41f47bb commit 07cfebf
Show file tree
Hide file tree
Showing 62 changed files with 51,146 additions and 53,427 deletions.
137 changes: 136 additions & 1 deletion doc/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,5 +1,140 @@
===============================================================

Tag name: cam_cesm2_2_rel_06
Originator(s): fvitt
Date: 6 Jan 2023
One-line Summary: Transport CL and BR in WACCM-MA chemistry mechanisms
Github PR URL: https://github.com/ESCOMP/CAM/pull/434

Purpose of changes (include the issue number and title text for each relevant GitHub issue):

Need to transport CL and BR #314

Describe any changes made to build system: NA

Describe any changes made to the namelist: NA

List any changes to the defaults for the boundary datasets: NA

Describe any substantial timing or memory changes: NA

Code reviewed by: cacraig

List all files eliminated: NA

List all files added and what they do: NA

List all existing files that have been modified, and describe the changes:

M src/chemistry/pp_waccm_ma/chem_mech.doc
M src/chemistry/pp_waccm_ma/chem_mech.in
M src/chemistry/pp_waccm_ma/chem_mods.F90
M src/chemistry/pp_waccm_ma/m_spc_id.F90
M src/chemistry/pp_waccm_ma/mo_adjrxt.F90
M src/chemistry/pp_waccm_ma/mo_indprd.F90
M src/chemistry/pp_waccm_ma/mo_lin_matrix.F90
M src/chemistry/pp_waccm_ma/mo_lu_factor.F90
M src/chemistry/pp_waccm_ma/mo_lu_solve.F90
M src/chemistry/pp_waccm_ma/mo_nln_matrix.F90
M src/chemistry/pp_waccm_ma/mo_prod_loss.F90
M src/chemistry/pp_waccm_ma/mo_rxt_rates_conv.F90
M src/chemistry/pp_waccm_ma/mo_sim_dat.F90
- remove CL and BR from the not-transported list
- add HO2 to the not-transported list

M src/chemistry/pp_waccm_ma_mam4/chem_mech.doc
M src/chemistry/pp_waccm_ma_mam4/chem_mech.in
M src/chemistry/pp_waccm_ma_mam4/chem_mods.F90
M src/chemistry/pp_waccm_ma_mam4/m_rxt_id.F90
M src/chemistry/pp_waccm_ma_mam4/m_spc_id.F90
M src/chemistry/pp_waccm_ma_mam4/mo_adjrxt.F90
M src/chemistry/pp_waccm_ma_mam4/mo_indprd.F90
M src/chemistry/pp_waccm_ma_mam4/mo_lin_matrix.F90
M src/chemistry/pp_waccm_ma_mam4/mo_lu_factor.F90
M src/chemistry/pp_waccm_ma_mam4/mo_lu_solve.F90
M src/chemistry/pp_waccm_ma_mam4/mo_nln_matrix.F90
M src/chemistry/pp_waccm_ma_mam4/mo_prod_loss.F90
M src/chemistry/pp_waccm_ma_mam4/mo_rxt_rates_conv.F90
M src/chemistry/pp_waccm_ma_mam4/mo_setrxt.F90
M src/chemistry/pp_waccm_ma_mam4/mo_sim_dat.F90
- remove CL and BR from the not-transported list

M src/chemistry/pp_waccm_mad/chem_mech.doc
M src/chemistry/pp_waccm_mad/chem_mech.in
M src/chemistry/pp_waccm_mad/chem_mods.F90
M src/chemistry/pp_waccm_mad/m_spc_id.F90
M src/chemistry/pp_waccm_mad/mo_adjrxt.F90
M src/chemistry/pp_waccm_mad/mo_exp_sol.F90
M src/chemistry/pp_waccm_mad/mo_imp_sol.F90
M src/chemistry/pp_waccm_mad/mo_indprd.F90
M src/chemistry/pp_waccm_mad/mo_lin_matrix.F90
M src/chemistry/pp_waccm_mad/mo_lu_factor.F90
M src/chemistry/pp_waccm_mad/mo_lu_solve.F90
M src/chemistry/pp_waccm_mad/mo_nln_matrix.F90
M src/chemistry/pp_waccm_mad/mo_prod_loss.F90
M src/chemistry/pp_waccm_mad/mo_rxt_rates_conv.F90
M src/chemistry/pp_waccm_mad/mo_setrxt.F90
M src/chemistry/pp_waccm_mad/mo_sim_dat.F90
- remove CL and BR from the not-transported list
- add HO2 to the not-transported list
- explicitly solve CO2 to be consistent with other waccm mechanisms
- use scalar solver for d-region ion chemistry mechanisms (mad)

M src/chemistry/pp_waccm_mad_mam4/chem_mech.doc
M src/chemistry/pp_waccm_mad_mam4/chem_mech.in
M src/chemistry/pp_waccm_mad_mam4/chem_mods.F90
M src/chemistry/pp_waccm_mad_mam4/m_rxt_id.F90
M src/chemistry/pp_waccm_mad_mam4/m_spc_id.F90
M src/chemistry/pp_waccm_mad_mam4/mo_adjrxt.F90
M src/chemistry/pp_waccm_mad_mam4/mo_exp_sol.F90
M src/chemistry/pp_waccm_mad_mam4/mo_imp_sol.F90
M src/chemistry/pp_waccm_mad_mam4/mo_indprd.F90
M src/chemistry/pp_waccm_mad_mam4/mo_lin_matrix.F90
M src/chemistry/pp_waccm_mad_mam4/mo_lu_factor.F90
M src/chemistry/pp_waccm_mad_mam4/mo_lu_solve.F90
M src/chemistry/pp_waccm_mad_mam4/mo_nln_matrix.F90
M src/chemistry/pp_waccm_mad_mam4/mo_prod_loss.F90
M src/chemistry/pp_waccm_mad_mam4/mo_rxt_rates_conv.F90
M src/chemistry/pp_waccm_mad_mam4/mo_setrxt.F90
M src/chemistry/pp_waccm_mad_mam4/mo_sim_dat.F90
- remove CL and BR from the not-transported list
- use scalar solver for d-region ion chemistry mechanisms (mad)

If there were any failures reported from running test_driver.sh on any test
platform, and checkin with these failures has been OK'd by the gatekeeper,
then copy the lines from the td.*.status files for the failed tests to the
appropriate machine below. All failed tests must be justified.

cheyenne/intel/aux_cam:
fvitt@cheyenne6:/glade/scratch/fvitt/aux_cam_20230105154916> cs.status.aux_cam_20230105154916 | grep -v PASS | grep Overall
ERP_Ln9.ne30pg3_ne30pg3_mg17.FW2000climo.cheyenne_intel.cam-outfrq9s_wcm_ne30 (Overall: FAIL) details:
- pre-existing failure

ERC_D_Ln9.f19_f19_mg17.QPX2000.cheyenne_intel.cam-outfrq3s_waccm_ma (Overall: DIFF) details:
ERC_D_Ln9.f19_f19_mg17.QPX2000.cheyenne_intel.cam-outfrq3s_WX81 (Overall: DIFF) details:
ERP_Lh12.f19_f19_mg17.FW4madSD.cheyenne_intel.cam-outfrq3h (Overall: DIFF) details:
ERS_Ln9.f09_f09_mg17.FX2000.cheyenne_intel.cam-outfrq9s (Overall: DIFF) details:
ERS_Ln9.f19_f19_mg17.FXSD.cheyenne_intel.cam-outfrq9s (Overall: DIFF) details:
SMS_D_Ln9.f19_f19_mg17.FWma2000climo.cheyenne_intel.cam-outfrq9s (Overall: DIFF) details:
SMS_D_Ln9.f19_f19_mg17.FXHIST.cheyenne_intel.cam-outfrq9s_amie (Overall: DIFF) details:
- expected baseline failures due to change in WACCM-MA chemistry mechanisms

izumi/nag/aux_cam:
DAE.f45_f45_mg37.FHS94.izumi_nag.cam-dae (Overall: FAIL) details:
- pre-existing failure

ERC_D_Ln9.f10_f10_mg37.QPC4X.izumi_nag.cam-outfrq3s_newyear (Overall: DIFF) details:
ERC_D_Ln9.f10_f10_mg37.QPWmaC6.izumi_nag.cam-outfrq3s (Overall: DIFF) details:
SMS_P48x1_D_Ln9.f19_f19_mg17.FW4madSD.izumi_nag.cam-outfrq9s (Overall: DIFF) details:
- expected baseline failures due to change in WACCM-MA chemistry mechanisms

izumi/pgi/aux_cam: All PASS

Summarize any changes to answers: Larger than roundoff for WACCM-MA configurations

===============================================================
===============================================================

Tag name: cam_cesm2_2_rel_05
Originator(s): peverwhee, lauritzen
Date: January 4, 2023
Expand Down Expand Up @@ -183,7 +318,7 @@ platform, and checkin with these failures has been OK'd by the gatekeeper,
then copy the lines from the td.*.status files for the failed tests to the
appropriate machine below. All failed tests must be justified.

Standard regression testing was not made as it would not uncover any errors in this modification.
Standard regression testing was not made as it would not uncover any errors in this modification.
Instead, ran:
./create_newcase --case test_FSCAM --compset FSCAM --res T42_T42
cd test_FSCAM
Expand Down
Loading

0 comments on commit 07cfebf

Please sign in to comment.