Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add instructions to get data from ERDDAP. Fixes (#147) #152

Merged
merged 7 commits into from
Feb 28, 2024

Conversation

salvafern
Copy link
Collaborator

@salvafern salvafern commented Apr 7, 2023

Fix #147

@salvafern salvafern requested a review from maelle April 7, 2023 11:04
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dd9b2b6) 85.99% compared to head (eb06110) 85.99%.

❗ Current head eb06110 differs from pull request most recent head 2e32545. Consider uploading reports for the commit 2e32545 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files           9        9           
  Lines         307      307           
=======================================
  Hits          264      264           
  Misses         43       43           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also mention (no need for an example) EMODnetWCS?

@salvafern
Copy link
Collaborator Author

Done :)

@salvafern salvafern requested a review from maelle April 12, 2023 09:57
@salvafern salvafern self-assigned this Apr 12, 2023
Copy link
Collaborator

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thank you!

DESCRIPTION Outdated
@@ -41,6 +41,7 @@ Suggests:
knitr,
mapview,
readr,
rerddap,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why list it here? maybe rather in a special field à la Config/Needs see https://r-pkgs.org/description.html#sec-description-custom-fields?

README.Rmd Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
@maelle maelle merged commit 972cad2 into main Feb 28, 2024
0 of 7 checks passed
@maelle maelle deleted the sf-related-pkgs branch February 28, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add section about related packages to README
3 participants