Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submission template #173

Merged
merged 3 commits into from
Sep 3, 2024
Merged

submission template #173

merged 3 commits into from
Sep 3, 2024

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Sep 2, 2024

For your review @salvafern (I won't submit without your feedback and approval 😇 )

For info @annakrystalli @JoBeja (but your feedback is most welcome!)

@maelle maelle requested a review from salvafern September 2, 2024 12:43

- Who is the target audience and what are scientific applications of this package?

The target audience of the package are researchers like marine ecologists, that might need EMODnet geographic vector data.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe one of you might have a suggestion of a bit more content here?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target audience is all EMODnet users, not just researchers and not just marine ecologists, so maybe something more like
"The target audience of the package are EMODnet users that might need EMODnet's geographic vector data "

Should we say something about downloading everything in one go via one query, as opposed to the human interface (e.g. viewer/catalogue) that requires a bit more user interaction?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.31%. Comparing base (77ed529) to head (643dd5b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   93.31%   93.31%           
=======================================
  Files           9        9           
  Lines         359      359           
=======================================
  Hits          335      335           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@salvafern salvafern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added the changes @JoBeja suggested at #173 (comment) on 643dd5b

Besides this little change, all good for me! Thanks @maelle 🙌

@maelle maelle merged commit 5b516d4 into main Sep 3, 2024
10 checks passed
@maelle maelle deleted the submission branch September 3, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants