-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapping function plugin system #152
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #152 +/- ##
==========================================
+ Coverage 75.21% 76.05% +0.84%
==========================================
Files 17 17
Lines 1416 1491 +75
==========================================
+ Hits 1065 1134 +69
- Misses 351 357 +6 ☔ View full report in Codecov by Sentry. |
…on-repo-plugin-system
…L/tripper into 128-function-repo-plugin-system
…L/tripper into 128-function-repo-plugin-system
tests/test_eval_function.py
Outdated
func_name="ufloat", | ||
module_name="uncertainties", | ||
# package_name="uncertainties", | ||
pypi_package_name="uncertainties", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add version number
if not kwargs: | ||
kwargs = {} | ||
|
||
# FIXME: Add sandboxing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an issue to address this FIXME?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An issue has now been created: #167
@jesper-friis Merge at your own convenience |
Description:
Closes #128
See #128 for design and reasoning behind this PR. Needed for using mapping functions in OTEAPI pipelines.
Type of change:
Checklist for the reviewer:
This checklist should be used as a help for the reviewer.