use mixin class for tensorflow #221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoors
commented
Dec 27, 2024
Comment on lines
-97
to
-101
| # TODO: implement | ||
| # It should bind to socket, but different MPIs may have different arguments to do that... | ||
| # We should at very least prevent that it binds to single core per process, | ||
| # as that results in many threads being scheduled to one core. | ||
| # binding may also differ per launcher used. It'll be hard to support a wide range and still get proper binding |
There was a problem hiding this comment.
@casparvl these comments can be removed, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.