Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use mixin class for gromacs #194

Merged
merged 8 commits into from
Nov 13, 2024
Merged

use mixin class for gromacs #194

merged 8 commits into from
Nov 13, 2024

Conversation

smoors
Copy link
Collaborator

@smoors smoors commented Oct 13, 2024 •
edited
Loading

same changes added to the mixin class as in #193

@smoors smoors marked this pull request as draft October 13, 2024 10:54
@smoors smoors marked this pull request as ready for review October 13, 2024 12:36
@smoors smoors changed the title use mixin class for gromacs use mixin class for cp2k and gromacs Oct 13, 2024
@smoors smoors changed the title use mixin class for cp2k and gromacs use mixin class for gromacs Oct 13, 2024
casparvl
casparvl approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@casparvl casparvl merged commit caf5391 into EESSI:main Nov 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casparvl casparvl casparvl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smoors @casparvl