Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CUDA 12.1.1, CUDA samples, and CUDA related hooks and lmodrc changes #434
Add CUDA 12.1.1, CUDA samples, and CUDA related hooks and lmodrc changes #434
Changes from 6 commits
fcc7ddb
2b09d1c
62e70ba
045c099
4a4c6e7
0346b22
5ec4c3b
5905e72
73618a0
46727cb
039921b
a4e8de7
32925fe
94a2bfe
a33a0cd
c7b380d
f506566
e3ddacc
16ddf7f
35d6084
fd97667
1917146
f80f0fc
2d37842
f007c40
70fa0f9
db0c141
293b107
73476b2
a333a74
43c73c0
3ec3df8
42e3404
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we are shipping scripts then the GPU stuff should appear as a subdir in there, I'll try to make a PR tonight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't let that block this PR, since we have things in a working state to get
CUDA-Samples
installed, so should be in a follow-up PR.I'm actually very much in favor of not shipping the scripts in the EESSI repository just yet, and to provide instructions in the documentation to clone the
software-layer
repo instead, for now...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean
/cvmfs/reponame/scripts/gpu_support
? I thought about that as well. I think it is cleaner, but note that the scripts often assume other files to be present in certain relative paths. So you'll have to make sure to adjust these.I could try to have a look in a minute...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boegel this PR is already shipping the scripts...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, I think it's more convenient for the end user to have this self-documenting via Lmod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs can be updated to have version-specific info, so that's not exactly true.
Lmod hook could be updated to point to
https://eessi.io/docs/gpu/2027.09
, andhttps://eessi.io/docs/gpu
could be set up to auto-redirect tohttps://eessi.io/docs/gpu/2023.06
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't think thats a lot of extra effort for little gain?
Personally, I think there are plenty of people who do not care how it works, just that it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can always add the docs pointers in the scripts if they're actually needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some people, just getting it to work will be enough.
Not for system administrators though, they won't go and run a random script just because they're told to.
They may even want to do what needs to be done some other way (through Puppet or whatever).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure but then you are sculpting things for minority use case (sysadmins).
Anyway, we can do both, the Lmod hook can mention the script and the docs, let the users decide