Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only create & bind build_logs_dir and shared_fs_path if they are specified #342

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

boegel
Copy link
Contributor

@boegel boegel commented Sep 26, 2023

This fixes early failures in the build job when shared_fs_path or build_logs_dir are not specified in the bot configuration.

Only trace of this in job output is the bot/build.sh script finishing very early (because set -e is used in bot/build.sh)

bot/build.sh: SHARED_FS_PATH=''
mkdir: missing operand
Try 'mkdir --help' for more information.
bot/build.sh finished

@boegel boegel added bug Something isn't working pilot-2023.06 labels Sep 26, 2023
@eessi-bot
Copy link

eessi-bot bot commented Sep 26, 2023

Instance eessi-bot-citc-aws is configured to build:

  • arch x86_64/generic for repo eessi-2021.12
  • arch x86_64/generic for repo eessi.org-2023.06-compat
  • arch x86_64/generic for repo eessi.io-2023.06-compat
  • arch x86_64/generic for repo eessi-2023.06-software
  • arch x86_64/intel/haswell for repo eessi-2021.12
  • arch x86_64/intel/haswell for repo eessi.org-2023.06-compat
  • arch x86_64/intel/haswell for repo eessi.io-2023.06-compat
  • arch x86_64/intel/haswell for repo eessi-2023.06-software
  • arch x86_64/intel/skylake_avx512 for repo eessi-2021.12
  • arch x86_64/intel/skylake_avx512 for repo eessi.org-2023.06-compat
  • arch x86_64/intel/skylake_avx512 for repo eessi.io-2023.06-compat
  • arch x86_64/intel/skylake_avx512 for repo eessi-2023.06-software
  • arch x86_64/amd/zen2 for repo eessi-2021.12
  • arch x86_64/amd/zen2 for repo eessi.org-2023.06-compat
  • arch x86_64/amd/zen2 for repo eessi.io-2023.06-compat
  • arch x86_64/amd/zen2 for repo eessi-2023.06-software
  • arch x86_64/amd/zen3 for repo eessi-2021.12
  • arch x86_64/amd/zen3 for repo eessi.org-2023.06-compat
  • arch x86_64/amd/zen3 for repo eessi.io-2023.06-compat
  • arch x86_64/amd/zen3 for repo eessi-2023.06-software
  • arch aarch64/generic for repo eessi-2021.12
  • arch aarch64/generic for repo eessi.org-2023.06-compat
  • arch aarch64/generic for repo eessi.io-2023.06-compat
  • arch aarch64/generic for repo eessi-2023.06-software
  • arch aarch64/neoverse_n1 for repo eessi-2021.12
  • arch aarch64/neoverse_n1 for repo eessi.org-2023.06-compat
  • arch aarch64/neoverse_n1 for repo eessi.io-2023.06-compat
  • arch aarch64/neoverse_n1 for repo eessi-2023.06-software
  • arch aarch64/neoverse_v1 for repo eessi-2021.12
  • arch aarch64/neoverse_v1 for repo eessi.org-2023.06-compat
  • arch aarch64/neoverse_v1 for repo eessi.io-2023.06-compat
  • arch aarch64/neoverse_v1 for repo eessi-2023.06-software

@boegel boegel mentioned this pull request Sep 26, 2023
@bedroge bedroge merged commit f9a0f77 into EESSI:2023.06 Sep 26, 2023
105 checks passed
@boegel boegel deleted the check_build_logs_dir_shared_fs_path branch September 26, 2023 19:38
trz42 added a commit to trz42/software-layer that referenced this pull request May 1, 2024
Add fix for permissions set on Lmod SitePackage and fixed spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pilot-2023.06
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants