first version of bot/check-result.sh script
#241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- follows what has been implemented in the EESSI/eessi-bot-software-layer for checking the result of a job - re-uses code from a small script that was run manually on a bot instance to check a job's result - also re-uses code from the check-result.sh script in EESSI/compatibility-layer
|
Instance
|
Merged
1 task
|
@trz42 Let's re-target this to the |
Sure. How do we (I) do that? |
If you hit |
Changed. |
boegel
requested changes
Jun 19, 2023
boegel
requested changes
Jun 20, 2023
boegel
requested changes
Jun 20, 2023
|
Tested along with EESSI/eessi-bot-software-layer#174 via boegel#25, works like a charm. Thanks (again) for all the effort on this @trz42! I've collapsed this into #260 so we can merge this cleanly in one go without ignoring failing CI checks... |
boegel
approved these changes
Jun 20, 2023
TopRichard
pushed a commit
to TopRichard/bot-software-layer1
that referenced
this pull request
Jan 22, 2024
…t_nessi.no renamed CI file and ported changes from EESSI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been tested with NESSI bot instances (see NorESSI/software-layer PR125). It requires EESSI/eessi-bot-software-layer PR174.
Because the tests for NESSI included other changes than just EESSI/eessi-bot-software-layer PR174 it would be good to repeat a more limited test.
The script contains extensive sections with examples for HTML blobs for how the produced result to be added to PR comment looks. They might be moved elsewhere (for documentation purposes) or removed.
The script is also quite long. Mostly because it really intends to support the bot to just use anything produced by the script. Probably this could be improved.
Retargeted to EESSI/2023.06.