-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add software required for 'mag' Nextflow pipeline to EESSI 2021.12 #202
add software required for 'mag' Nextflow pipeline to EESSI 2021.12 #202
Conversation
eessi-2021.12.yml
Outdated
@@ -57,3 +57,7 @@ software: | |||
toolchains: | |||
SYSTEM: | |||
versions: '22.10.1' | |||
Nextflow-mag-pipeline: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is premature here I think, there is no PR (that I can find) for Nextflow-mag-pipeline-2.2.1-foss-2021a.eb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should be a good name in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use Nextflow-pipeline
, and use -mag
as versionsuffix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But doesn't this have to map to an easyconfig? Is there a PR somewhere (for Nextflow-pipeline-2.2.1-foss-2021a-mag.eb
) being worked on that wraps all the other PRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pipeline is actually called nf-core/mag
, I'd be inclined to stick close to that so people can actually find it...not sure how we deal with /
though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smoretti For MetaBAT
, the updated EasyBuild hooks from #203 are also required, because the fixed MetaBAT easyconfigs in easybuilders/easybuild-easyconfigs#16624 assume that $EBROOTZLIB
is defined, which it is not in the EESSI build environment because we filter out zlib
as depedency via --filter-deps
(see our script to configure EasyBuild).
EESSI-pilot-install-software.sh
Outdated
echo ">> Installing requirements for the Nextflow mag 20221110 pipeline..." | ||
ok_msg="The full Nextflow pipeline is installed, the work must flow..." | ||
fail_msg="Installation of the Nextflow pipeline failed, that's unexpected..." | ||
$EB --robot --from-pr 16576,16577,16589,16590,16591,16592,16612,16613,16615,16617 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smoretti This should be trimmed to:
$EB --from-pr 16613 --robot
As long as all PRs required by easybuilders/easybuild-easyconfigs#16613 are merged (most, if not all, already are), then that's sufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Just for context, this requires 115 additional installations in total (assuming that both #160 and #195 are already installed), see details below.
|
If not, we'll run into this:
|
For MetaBAT on Bowtie2 on
It seems like SIMDe needs to be added as a dependency (at least on non- |
…make sure all SHA256 checksums for extensions are correct AND to speed up the installation with --parallel-extensions-install
… instead of True in dependencies
|
…9.1.1-foss/2022a {2023.06}[foss/2022a] Pillow V9.1.1
Since this is targeting the old and unsupported pilot repository, I'm going to close this PR. If it's still relevant to add this to EESSI, please open a new PR where this is added to one of the easystack files for the production repository. |
Nextflow pipeline https://nf-co.re/mag ported in EESSI