-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support in init script for using 'archdetect' alternative to archspec (only if $EESSI_USE_ARCHDETECT is set to '1') #187
Conversation
@hmeiland I've gone through this PR one more time and it looks fine on my side. All I can think of as improvement at this point is to enhance the logging and comments in the script. I made the following changes in PR hmeiland#3:
You will see that the diff looks like I rewrote most of the script, but that's mainly because I standardize the indentation to 4 spaces. |
standarize log formatting by adding logging function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Kenneth Hoste <[email protected]>
I've tested this in various systems, works as expected:
I've also tested this on:
|
{2023.06}[foss/2022a] add SciPy-bundle
alternative for archspec
not enabled by default: require EESSI_USE_ARCHDETECT to be used (for now)