clarify cpu part identification for ARM

EESSI · Jan 18, 2023 · c858fb4 · c858fb4
1 parent 24b84d4
commit c858fb4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/init/arch_specs/eessi_arch_arm_part.spec b/init/arch_specs/eessi_arch_arm_part.spec
@@ -1,5 +1,5 @@
 # ARM CPU architecture specifications
-# Software path in EESSI 	| Vendor ID 	| List of defining CPU features
+# Software path in EESSI 	| Vendor ID 	| CPU part (ARM uarch identification) 
 "aarch64/arm/cortex-a72"	""		"0xd08" 	# Raspberry Pi 4 
 "aarch64/arm/neoverse-n1"	""		"0xd0c"		# AWS Graviton2
 "aarch64/arm/neoverse-v1"	""		"0xd40"		# AWS Graviton3
diff --git a/init/eessi_archdetect.sh b/init/eessi_archdetect.sh
@@ -83,7 +83,7 @@ cpupath(){
     local cpu_vendor=$(get_cpuinfo "$cpu_vendor_tag")
     log "DEBUG" "cpupath: CPU vendor of host system: '$cpu_vendor'"
 
-    # Identify the host CPU part 
+    # Identify the host CPU part
     local cpu_part_tag="cpu[ _]part"
     local cpu_part=$(get_cpuinfo "$cpu_part_tag")
     log "DEBUG" "cpupath: CPU part of host system: '$cpu_part'"
@@ -92,6 +92,7 @@ cpupath(){
     case $machine_type in
         "x86_64") local spec_file="eessi_arch_x86.spec";;
         "aarch64") 
+                # look for ARM core identification through cpu part when available, otherwise fall back to features  
 		local spec_file="eessi_arch_arm.spec"
     		[ ! "${cpu_part}x" == "x" ] && local spec_file="eessi_arch_arm_part.spec" 
 		;;