-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial version of bot/check-result.sh
script
#179
Draft
trz42
wants to merge
25
commits into
EESSI:main
Choose a base branch
from
trz42:bot_check_result_script
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- scripts/utils.sh is borrowed from software-layer. it includes various functions to be used with other scripts in this repo. - scripts/cfg_files.sh is borrowed from software-layer. it provides functions to read a file that contains information about a job. - changes to bot/build.sh: - added header, author, license - added assumptions - added set -e - source the above helper scripts - read job.cfg file - set core settings if needed: HTTP_PROXY, HTTPS_PROXY, LOCAL_TMP, LOAD_MODULES - expand LOCAL_TMP into STORAGE - load modules - obtain cpu_target_arch from job.cfg setting - bump eessi_version to 2023.04 - calling install_compatibility_layer.sh: remove fixed local container, add storage option
- add arguments for resuming, retaining tmp and more verbose output - extended and reformatted usage information - source helper script scripts/utils.sh - add support to resume a previous run given its temporary directory - determine container runtime (singularity or apptainer) - define env vars for both singularity and apptainer - unset PKG_CONFIG_PATH before running ansible script - only tar temporary directory if --retain-tmp option is given - add message for how to resume a previous run
…all if list not empty)
…rapping tasks (because pipefail is needed)
- added some debugging - remove any existing virtualenv - make sure ReFrame is installed - left some more example debugging (could be cleaned up)
added ```ansible vars: ansible_python_interpreter: "{{ gentoo_prefix_path }}/usr/bin/python3" ``` to all tasks using communit.general.portage
Instance
|
Merged
1 task
@trz42 ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More a proof-of-concept than a final/ready version. However, good enough to use it as a base for creating a new PR to let the bot build the compatibility layer and check the result of the building.
The script needs to be polished by removing stuff that isn't needed and also by running all the checks that are necessary to evaluate if a compatibility layer has been built successfully.