Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks component #18

Merged
merged 15 commits into from
Nov 14, 2019
Merged

Tasks component #18

merged 15 commits into from
Nov 14, 2019

Conversation

Fizzadar
Copy link
Contributor

@Fizzadar Fizzadar commented Nov 12, 2019

Currently adds a basic tasks dashboard:

Screenshot 2019-11-12 at 11 31 36

TODO:

  • show/view sub-tasks
  • pretty format running time without breaking sorting
  • periodic updating / manual update button
  • controls to show/hide child tasks

Closes: #15
Closes: #16
Closes: #19

@Fizzadar Fizzadar self-assigned this Nov 12, 2019
@Fizzadar Fizzadar changed the title [WIP] Tasks + clusters components Tasks component Nov 13, 2019
Copy link
Member

@gchazot gchazot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a couple of suggestions

frontend/src/TasksDashboard.jsx Outdated Show resolved Hide resolved
Comment on lines +28 to +30
curl -X PUT http://dev.edtd.net:26950/.elasticsurgery-clusters/_doc/<SLUG> \
-H 'Content-Type: application/json' \
-d@my_json_config.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a script to simplify this, and also use it in the migrations section of kubetools.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already happens during ktd up for the dev cluster - the clusters UI should remove the need for this entirely once implemented, so a temporary readme addition!

@Fizzadar
Copy link
Contributor Author

Thanks for the review @gchazot!

@Fizzadar Fizzadar merged commit bf117fa into master Nov 14, 2019
@Fizzadar Fizzadar deleted the tasks-clusters-components branch November 14, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cluster tasks dashboard Fix inconsistent action/variable. Naming check
2 participants